Add: give map label text the ability to have an outline#7598
Merged
vadi2 merged 11 commits intoMudlet:developmentfrom Dec 27, 2024
Merged
Add: give map label text the ability to have an outline#7598vadi2 merged 11 commits intoMudlet:developmentfrom
vadi2 merged 11 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
Author
Fixed this. |
vadi2
approved these changes
Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Brief overview of PR changes/additions
Add an outline colour chooser to map label creation window in mapper. Update createMapLabel Lua function to reflect this as well. Adds three optional arguments to the end of createMapLabel( ..., outlineRed, outlineGreen, outlineBlue), default to the same colour as foreground if not specified.
Also, chosen colours weren't being saved from one dialog to the next forcing unnecessary typing to replicate a colour scheme when creating multiple labels, so fix this and allow chosen colours to also save across Mudlet restarts as well.
Motivation for adding to Mudlet
Better user experience, more map design options, prettier maps.
Other info (issues closed, discussion etc)
Zoomed in;

closes #2861
/claim #2861