Skip to content

Improve: Add default template for new package in package exporter#7041

Merged
vadi2 merged 1 commit intoMudlet:developmentfrom
ZookaOnGit:default-package-template-5079
Dec 24, 2023
Merged

Improve: Add default template for new package in package exporter#7041
vadi2 merged 1 commit intoMudlet:developmentfrom
ZookaOnGit:default-package-template-5079

Conversation

@ZookaOnGit
Copy link
Copy Markdown
Contributor

Brief overview of PR changes/additions

Add default template in markdown. Change textEdit_description behavior to not clear on first click by assigning the markdown text on initialisation.

Motivation for adding to Mudlet

/claim #5079

Other info (issues closed, discussion etc)

Closes #5079.

We should possibly look at making textEdit_description larger to encourage the coder to make use of the space and help visually see the markdown. Perhaps make it full window and using a two column display with the editor using the entire right-side column.

Peek 2023-12-21 15-52

@ZookaOnGit ZookaOnGit requested a review from a team as a code owner December 21, 2023 08:54
@ZookaOnGit ZookaOnGit requested a review from a team December 21, 2023 08:54
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Dec 21, 2023

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@ZookaOnGit ZookaOnGit changed the title Add default template for new package in package exporter Improve: Add default template for new package in package exporter Dec 21, 2023
Copy link
Copy Markdown
Member

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @Kebap could you review also?

@Kebap
Copy link
Copy Markdown
Contributor

Kebap commented Dec 21, 2023

Yes, does what it should! 👍

@wiploo
Copy link
Copy Markdown
Contributor

wiploo commented Dec 23, 2023

Hi! @ZookaOnGit thanks for you PR. I think that the information added are clear but the description spaces is too narrow. Can you let it open like the "NOTE" (for example) using a button or something similar.?

It is impossible to write a long description in such a small space.

Best Regards

@ZookaOnGit
Copy link
Copy Markdown
Contributor Author

ZookaOnGit commented Dec 23, 2023

I'll create another ticket as the request is outside the scope of this issue/PR, and I don't have the required coding skills unfortunately.

Edit: Further discussion on #7051

@vadi2 vadi2 merged commit 9230d14 into Mudlet:development Dec 24, 2023
vadi2 pushed a commit to vadi2/Mudlet that referenced this pull request Dec 24, 2023
…dlet#7041)

<!-- Keep the title short & concise so anyone non-technical can
understand it,
     the title appears in PTB changelogs -->
#### Brief overview of PR changes/additions
Add default template in markdown. Change textEdit_description behavior
to not clear on first click by assigning the markdown text on
initialisation.

#### Motivation for adding to Mudlet
/claim Mudlet#5079 

#### Other info (issues closed, discussion etc)
Closes Mudlet#5079.  

We should possibly look at making textEdit_description larger to
encourage the coder to make use of the space and help visually see the
markdown. Perhaps make it full window and using a two column display
with the editor using the entire right-side column.

![Peek 2023-12-21
15-52](https://github.com/Mudlet/Mudlet/assets/136661366/c6235848-bdb9-4f16-b572-2d3f72fa7db8)
@ZookaOnGit ZookaOnGit deleted the default-package-template-5079 branch December 27, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add default template for packages in exporter

4 participants