Infrastructure: rename pF -> pParentWidget & fix some whitespace layouts#6379
Infrastructure: rename pF -> pParentWidget & fix some whitespace layouts#6379Kebap merged 5 commits intodevelopmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
SlySven
left a comment
There was a problem hiding this comment.
👍 LGTM but can we simultaneously also move those initialisation list entries to each be on a separate line - we used to do that but I think the clang-format doesn't do that automagically and we now have a mix of styles. What is nice about the one-per-line is that it is clearer if something gets added/removed/reordered - and whilst I am sure someone could object to this on the basis that it should be done in a separate PR it seems silly to defer that to that when it only affects constructors and we are already hitting one chunk of them here (though it is pushing at the dangerous limits 😀 ).
That would be me, no?
Ok let's assume I changed all of these here...
We still have a mix afterwards. Funny thing is, this tiny issue scope and PR stem from exactly the same kind of commenting related issues at PRs. It then got buried for almost 2 years after that PR was merged, until I accidentally stumbled across it while researching something else. There seems to be some sort of reluctance to post an actual issue to keep track of an idea, and a separate PR to fix the issue in the whole code base, which would actually be required to heal the mix of styles, yes? |
Co-authored-by: Stephen Lyons <slysven@virginmedia.com>
Okay - I'll try to run something up over this weekend to hit the remaining constructors - if I don't you can call me out on Discord...! 😏 |
|
No it's not important enough to do over the next 2-3 days immediately. Just open a low priority issue to remind yourself and others |
This is so they all have each member initialiser on a single line - so that changes can be more easily seen/comprehended in Git differences (as opposed to them all being on a long single line...!) This is a response to the comment: Mudlet#6379 (comment) Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This is so they all have each member initialiser on a single line - so that changes can be more easily seen/comprehended in Git differences (as opposed to them all being on a long single line...!) This is a response to the comment: Mudlet#6379 (comment) Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
…6387) This is so they all have each member initialiser on a single line - so that changes can be more easily seen/comprehended in Git differences (as opposed to them all being on a long single line...!) This is a response to the comment: #6379 (comment) Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
…6388) This is so they all have each member initialiser on a single line - so that changes can be more easily seen/comprehended in Git differences (as opposed to them all being on a long single line...!) This is a response to the comment: #6379 (comment) Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Brief overview of PR changes/additions
make variable name more readable
Motivation for adding to Mudlet
Improve readability
Other info (issues closed, discussion etc)
Fix #6375