Infrastructure: unify class constructor initialisers (Part 2 0f 2)#6388
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Oct 24, 2022
Conversation
This is so they all have each member initialiser on a single line - so that changes can be more easily seen/comprehended in Git differences (as opposed to them all being on a long single line...!) This is a response to the comment: Mudlet#6379 (comment) Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Kebap
reviewed
Oct 24, 2022
| @@ -1,5 +1,6 @@ | |||
| /*************************************************************************** | |||
| * Copyright (C) 2020 by Mike Conley - sousesider[at]gmail.com * | |||
| * Copyright (C) 2022 by Stephen Lyons - slysven@virginmedia.com * | |||
Contributor
There was a problem hiding this comment.
As before, not really required to add yourself here for adding whitespace.
Kebap
approved these changes
Oct 24, 2022
Contributor
Kebap
left a comment
There was a problem hiding this comment.
Straightforward PR, easy to review!
demonnic
approved these changes
Oct 24, 2022
Member
demonnic
left a comment
There was a problem hiding this comment.
opens, connects, plays, tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is so they all have each member initialiser on a single line - so that changes can be more easily seen/comprehended in Git differences (as opposed to them all being on a long single line...!)
This is a response to the comment: #6379 (comment)
Signed-off-by: Stephen Lyons slysven@virginmedia.com