Add clang tools to docker build#5808
Merged
Chris7 merged 3 commits intoMudlet:developmentfrom Jan 2, 2022
Merged
Conversation
Co-authored-by: mudlet-machine-account <mudlet-machine-account@users.noreply.github.com>
Co-authored-by: mudlet-machine-account <mudlet-machine-account@users.noreply.github.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Contributor
vadi2
approved these changes
Jan 2, 2022
Member
|
Btw unrelated to this PR, but we have a duplicate Dockerfile already in https://github.com/Mudlet/Mudlet/blob/development/.devcontainer/Dockerfile which is used for github codespaces. Maybe the two could be combined? |
Member
Author
|
Hmm, it should work -- just need to figure out what the library names are in whatever distro the base image is based off. I'm not a user of github codespaces though, but could ensure whatever happens still works for the local development setup. |
vadi2
pushed a commit
to SlySven/Mudlet
that referenced
this pull request
Jan 17, 2022
* (autocommit) Updated autocompletion data (Mudlet#4034) Co-authored-by: mudlet-machine-account <mudlet-machine-account@users.noreply.github.com> * (autocommit) Updated autocompletion data (Mudlet#4501) Co-authored-by: mudlet-machine-account <mudlet-machine-account@users.noreply.github.com> * Add env var Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mudlet-machine-account <mudlet-machine-account@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Adds a few missing code quality tools to the docker env setup.