Improve: add a QSpinWidget for adjusting special exit weight in exit dialogue#5758
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Dec 14, 2021
Conversation
…dialog This uses the same method of providing a custom item delegate has been used for the special exit roomID column in the `QTreeWidget` derived `ExitsTreeWidget` in PR Mudlet#5543 but instead of making use of an enhanced `QlineEdit` this will replace the standard `QLineEdit` with a `QSpinBox` whilst the special exit's weight is being modified. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
6 tasks
Contributor
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
vadi2
approved these changes
Dec 14, 2021
vadi2
pushed a commit
to SlySven/Mudlet
that referenced
this pull request
Jan 17, 2022
…dialog (Mudlet#5758) This uses the same method of providing a custom item delegate has been used for the special exit roomID column in the `QTreeWidget` derived `ExitsTreeWidget` in PR Mudlet#5543 but instead of making use of an enhanced `QlineEdit` this will replace the standard `QLineEdit` with a `QSpinBox` whilst the special exit's weight is being modified. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the same method of providing a custom item delegate has been used for the special exit roomID column in the
QTreeWidgetderivedExitsTreeWidgetin PR #5543 but instead of making use of an enhancedQlineEditthis will replace the standardQLineEditwith aQSpinBoxwhilst the special exit's weight is being modified.This concludes the generation of separate chunks of code that was originally in #5308 but which was overlarge.
Signed-off-by: Stephen Lyons slysven@virginmedia.com
Release post highlight
Improve: the control to set a special exit's weighting is now a spinbox whilst it is being edited which can be adjusted between 0 and 9999 - like the controls for normal exits.