Skip to content

Add go to errors button in console toolbar#5293

Closed
Delwing wants to merge 1 commit intoMudlet:developmentfrom
Delwing:error-button-in-command-line-tools
Closed

Add go to errors button in console toolbar#5293
Delwing wants to merge 1 commit intoMudlet:developmentfrom
Delwing:error-button-in-command-line-tools

Conversation

@Delwing
Copy link
Copy Markdown
Contributor

@Delwing Delwing commented Jun 19, 2021

Brief overview of PR changes/additions

image

Motivation for adding to Mudlet

It's cumbersome to tell people how at access error logs. Should be easier... I had little temptation to put button in top toolbar, maybe this would make it even more obvious?

Other info (issues closed, discussion etc)

Release post highlight

@Delwing Delwing requested a review from a team as a code owner June 19, 2021 07:08
@Delwing Delwing requested a review from a team June 19, 2021 07:08
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Jun 19, 2021

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@github-actions
Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@Kebap
Copy link
Copy Markdown
Contributor

Kebap commented Jun 19, 2021

Not sure how I like adding more buttons in that area.. 🤔

I always recommend to activate "show lua errors in main console" in preferences.

How are people receiving interesting errors if they don't know the editor window? 🤔 do they want to bugfix themselves?

@Kebap
Copy link
Copy Markdown
Contributor

Kebap commented Jun 19, 2021

With #5280 added this will be possible with ctrl+e followed by ctrl+8 equally as well

@SlySven
Copy link
Copy Markdown
Member

SlySven commented Jun 20, 2021

I had little temptation to put button in top toolbar, maybe this would make it even more obvious?

Not if they have already hidden those buttons (with the compact input line option)!

@Delwing
Copy link
Copy Markdown
Contributor Author

Delwing commented Jun 20, 2021

Not sure how I like adding more buttons in that area.. 🤔

I always recommend to activate "show lua errors in main console" in preferences.

How are people receiving interesting errors if they don't know the editor window? 🤔 do they want to bugfix themselves?

This is more of a problem for script creators...

It's not working...
Can you check error logs?
Where are they?
:)
Veeeery common.

@vadi2
Copy link
Copy Markdown
Member

vadi2 commented Jun 23, 2021

Where are they?

Agree, I see the problem. It's a bit too much to have 7 buttons at the bottom though - what do you think of my proposal - Delwing#23

@Kebap
Copy link
Copy Markdown
Contributor

Kebap commented Jun 24, 2021

what do you think of my proposal - Delwing#23

Again I don't see the need to add this to main window at all, because it is not interesting for all players.
Delwing just confirmed, this issue is raised by script creators, so they already know the editor window.
That is where this belongs. Need to figure out, why they don't find the error button there by themselves.
Maybe they don't see the button when the window is too small? This will be true for main window as well.
Now that #5280 is merged, merely mentioning CTRL+8 should help with Delwing's original complaint that

It's cumbersome to tell people how at access error logs. Should be easier...

@SlySven
Copy link
Copy Markdown
Member

SlySven commented Jun 26, 2021

Comment on @vadi2 's PR to this PR: Delwing#23 (review) .

@Delwing
Copy link
Copy Markdown
Contributor Author

Delwing commented Jun 26, 2021

@Kebap it's raised by script creators when contacting with users... :) So when user is having an issue with scripts, his contacting creator, whom asks, whether use has any errors in console and there explaining starts :)
I like @vadi2 idea more, to put it on top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants