Skip to content

BugFix: handling of optional 3rd argument to getRoomUserData#4768

Merged
SlySven merged 1 commit intoMudlet:developmentfrom
SlySven:BugFix_handlingOfOptional3rdArgumentTo_getRoomUserData
Feb 10, 2021
Merged

BugFix: handling of optional 3rd argument to getRoomUserData#4768
SlySven merged 1 commit intoMudlet:developmentfrom
SlySven:BugFix_handlingOfOptional3rdArgumentTo_getRoomUserData

Conversation

@SlySven
Copy link
Copy Markdown
Member

@SlySven SlySven commented Feb 10, 2021

This was introduced by #4661.

Also revert to using raw string literal empty strings for some lua related functions that do not work with QStrings directly.

Signed-off-by: Stephen Lyons slysven@virginmedia.com

@SlySven
BugFix: handling of optional 3rd argument to getRoomUserData
cb61810 
This was introduced by Mudlet#4661.

Also revert to using raw string literal empty strings for some lua related
functions that do not work with `QString`s directly.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
@SlySven SlySven requested a review from a team as a code owner February 10, 2021 05:34
@SlySven SlySven requested review from a team February 10, 2021 05:34
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Feb 10, 2021 •
edited
Loading

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@SlySven SlySven added this to the 4.11.0 milestone Feb 10, 2021
Kebap
Kebap approved these changes Feb 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Kebap Kebap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo well fixed

Also revert to using raw string literal empty strings for some lua related functions that do not work with QStrings directly.

That was NOT introduced by #4661.

@SlySven
Copy link
Copy Markdown
Member Author

SlySven commented Feb 10, 2021

Also revert to using raw string literal empty strings for some lua related functions that do not work with QStrings directly.

That was NOT introduced by #4661.

Sorry, sub-optimal choice of words, I was trying to say that using QString() to generate an empty QString and then converting it to a const char* is not a positive move from a plain "" when it is to be fed to a Lua library function in C/C++ which takes a const char*... as it happens that pair date back to ead6989 (#340) which was done by... erm, me! 😊

@SlySven SlySven merged commit a8cc3b5 into Mudlet:development Feb 10, 2021
@SlySven SlySven deleted the BugFix_handlingOfOptional3rdArgumentTo_getRoomUserData branch February 11, 2021 01:15
Chris7 pushed a commit to Chris7/Mudlet that referenced this pull request Jan 2, 2022
@SlySven @Chris7
BugFix: handling of optional 3rd argument to getRoomUserData (Mudlet#…
1c73686 
…4768)

This was introduced by Mudlet#4661.

Also switch to using raw string literal empty strings for two lua related
function calls that do not work with `QString`s directly - which was introduced
in Mudlet#340 by myself!

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadi2 vadi2 vadi2 approved these changes

@Kebap Kebap Kebap approved these changes

Assignees

@vadi2 vadi2

Labels

medium regression

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@SlySven @vadi2 @Kebap