Skip to content

fix hecho to allow setting of background colour only (fix #4649)#4759

Merged
vadi2 merged 1 commit intoMudlet:developmentfrom
Edru2:fix-hecho-onlyBackgroundColor
Feb 6, 2021
Merged

fix hecho to allow setting of background colour only (fix #4649)#4759
vadi2 merged 1 commit intoMudlet:developmentfrom
Edru2:fix-hecho-onlyBackgroundColor

Conversation

@Edru2
Copy link
Copy Markdown
Member

@Edru2 Edru2 commented Feb 5, 2021

Brief overview of PR changes/additions

hecho didn't allow to set just the background colour in latest PTB anymore.
This fixes it.

Motivation for adding to Mudlet

fix #4649

Other info (issues closed, discussion etc)

hecho(" #,008000 This is a hecho test with green background\n")
is working again. The old examples are also still working.
Test with new underline/italic/bold settings.
hecho(" #,008000 This is a #ihecho#/i test with #bgreen#/b #ubackground#/u\n")

@Edru2 Edru2 requested a review from a team February 5, 2021 14:06
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Feb 5, 2021

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

Copy link
Copy Markdown
Member

@vadi2 vadi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, thanks 👍

@vadi2 vadi2 merged commit 48cb19d into Mudlet:development Feb 6, 2021
Chris7 pushed a commit to Chris7/Mudlet that referenced this pull request Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting background color without setting a foreground color in hecho is not working anymore (in latest development branch)

2 participants