BugFix: correct regression in getRoomName(...)#4742
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Feb 4, 2021
Merged
BugFix: correct regression in getRoomName(...)#4742SlySven merged 1 commit intoMudlet:developmentfrom
SlySven merged 1 commit intoMudlet:developmentfrom
Conversation
This is a recent bug introduced in the big error message handling code refactor. Also spotted a couple of uses of `QStringList::operator[]` where `QStringList::at(...)` would be better. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Chris7
pushed a commit
to Chris7/Mudlet
that referenced
this pull request
Jan 2, 2022
This is a recent bug introduced in the big error message handling code refactor. Also spotted a couple of uses of `QStringList::operator[]` where `QStringList::at(...)` would be better. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a recent bug introduced in the big error message handling code refactor.
Also spotted a couple of uses of
QStringList::operator[]whereQStringList::at(...)would be better.Signed-off-by: Stephen Lyons slysven@virginmedia.com