BugFix: correct missing detail (map label position) from binary map files#4694
Merged
vadi2 merged 1 commit intoMudlet:developmentfrom Jan 27, 2021
Conversation
…iles
This will cause serious data loss (because it throws off the whole
structure of the file) when reading existing files {because the label
position element is not read from the file so everything after the first
map label will not be at the expected offset} and writing new ones as they
would not be storing the position detail rendering all map labels at the
origin when read by the new code.
This defect was introduced in Mudlet#4604 - ten days ago.
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Member
Author
|
🤦♂️ I am sorry about this boo-boo. It means that any map files produced from the development branch since #4606 went in will be broken as the map label position was not included in the saved file - and then when read the missing detail will offset the bytes positions after the first map label so that all the remaining data, which includes ALL the rooms, will be corrupted. |
Contributor
|
Installed, reset my mapfile then exited/restarted a couple times. This fixes |
Chris7
pushed a commit
to Chris7/Mudlet
that referenced
this pull request
Jan 2, 2022
BugFix: correct missing detail (map label position) from binary map files
This will cause serious data loss (because it throws off the whole
structure of the file) when reading existing files {because the label
position element is not read from the file so everything after the first
map label will not be at the expected offset} and writing new ones as they
would not be storing the position detail rendering all map labels at the
origin when read by the new code.
This defect was introduced in Mudlet#4604 - ten days ago.
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will cause serious data loss (because it throws off the whole structure of the file) when reading existing files {because the label position element is not read from the file so everything after the first map label will not be at the expected offset} and writing new ones as they would not be storing the position detail rendering all map labels at the origin when read by the new code.
This defect was introduced in #4604 - ten days ago.
Signed-off-by: Stephen Lyons slysven@virginmedia.com