BugFix: initialise mDlgRoomSymbol so that settng room symbols works again#4687
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Jan 26, 2021
Conversation
…gain A test for this pointer being a `nullptr` is what enables a new dialogue to be made in the 2D mapper - by not initialising it in Mudlet#4573 a random non-null value is found so the dialogue and thus the functionality can be virtually impossible to use. As it is a pointer I have taken the liberty to introduce a `p` into the initial part of the name - after the `m` to indicate it is a class member. As the defect is a regression that causes loss of functionality I am rating this as a **high** priority bug(fix) even though it does not induce any fatal termination of the application. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
vadi2
approved these changes
Jan 26, 2021
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Jan 26, 2021
…gain (Mudlet#4687) A test for this pointer being a `nullptr` is what enables a new dialogue to be made in the 2D mapper - by not initialising it in Mudlet#4573 a random non-null value is found so the dialogue and thus the functionality can be virtually impossible to use. As it is a pointer I have taken the liberty to introduce a `p` into the initial part of the name - after the `m` to indicate it is a class member. As the defect is a regression that causes loss of functionality I am rating this as a **high** priority bug(fix) even though it does not induce any fatal termination of the application. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Chris7
pushed a commit
to Chris7/Mudlet
that referenced
this pull request
Jan 2, 2022
…gain (Mudlet#4687) A test for this pointer being a `nullptr` is what enables a new dialogue to be made in the 2D mapper - by not initialising it in Mudlet#4573 a random non-null value is found so the dialogue and thus the functionality can be virtually impossible to use. As it is a pointer I have taken the liberty to introduce a `p` into the initial part of the name - after the `m` to indicate it is a class member. As the defect is a regression that causes loss of functionality I am rating this as a **high** priority bug(fix) even though it does not induce any fatal termination of the application. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A test for this pointer being a
nullptris what enables a new dialogue to be made in the 2D mapper - by not initialising it in #4573 a random non-null value is found so the dialogue and thus the functionality can be virtually impossible to use.As it is a pointer I have taken the liberty to introduce a
pinto the initial part of the name - after themto indicate it is a class member.As the defect is a regression that causes loss of functionality I am rating this as a high priority bug(fix) even though it does not induce any fatal termination of the application.
Signed-off-by: Stephen Lyons slysven@virginmedia.com