BugFix: correct mis-use of nullptr to denote no room symbol colour#4679
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Jan 25, 2021
Conversation
It seems like PR Mudlet#4573 introduced a bogus use of pointer access to a `QColor` whereas the correct methodology is `QColor::isValid()` - a default constructed `QColor` is itself equivalent to an RGBA specified colour of `QColor(0,0,0,0)` and that will fail in that test. This PR fixes things so that (instead of a `nullptr` test) is used. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Member
Author
|
I am ranking this as a medium priority bugfix (without there being an explicit bug issue relating to it). OTOH if this is the underlying reason for any inexplicable crashes related to the map - it might be more important than that..! |
vadi2
approved these changes
Jan 25, 2021
Chris7
pushed a commit
to Chris7/Mudlet
that referenced
this pull request
Jan 2, 2022
…udlet#4679) It seems like PR Mudlet#4573 introduced a bogus use of pointer access to a `QColor` whereas the correct methodology is `QColor::isValid()` - a default constructed `QColor` is itself equivalent to an RGBA specified colour of `QColor(0,0,0,0)` and that will fail in that test. This PR fixes things so that (instead of a `nullptr` test) is used. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like PR #4573 introduced a bogus use of pointer access to a
QColorwhereas the correct methodology isQColor::isValid()- a default constructedQColoris itself equivalent to an RGBA specified colour ofQColor(0,0,0,0)and that will fail in that test. This PR fixes things so that (instead of anullptrtest) is used.Signed-off-by: Stephen Lyons slysven@virginmedia.com