BugFix: stop special exits being modified when old format maps are read#4574
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Jan 3, 2021
Conversation
Since Mudlet#4526 was merged into the development branch 4 days ago reading of old maps (formats *before* *8*) built from Mudlet prior to 8e0f9db (merged on 2011/01/24) will chop the first character from the name/command of every special exit... This was caused by a copy-paste error in the code that converted the older style of storing the special exits and their locked status that was used prior to that PR. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Member
Author
|
This is only a low priority bug because the chances of anyone using a map from a Mudlet produced before January 2011 - and not loaded since is highly unlikely! |
vadi2
approved these changes
Jan 3, 2021
Chris7
pushed a commit
to Chris7/Mudlet
that referenced
this pull request
Jan 2, 2022
…ad (Mudlet#4574) Since Mudlet#4526 was merged into the development branch 4 days ago reading of old maps (formats before 8) built from Mudlet prior to 8e0f9db (merged on 2011/01/24) will chop the first character from the name/command of every special exit... This was caused by a copy-paste error in the code that converted the older style of storing the special exits and their locked status that was used prior to that PR. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #4526 was merged into the development branch 4 days ago reading of old maps (formats before 8) built from Mudlet prior to 8e0f9db (merged on 2011/01/24) will chop the first character from the name/command of every special exit...
This was caused by a copy-paste error in the code that converted the older style of storing the special exits and their locked status that was used prior to that PR.
Signed-off-by: Stephen Lyons slysven@virginmedia.com