Skip to content

Resolve all conflicts in mudlet.{cpp,h} [ci skip]#449

Merged
SlySven merged 1 commit intoMudlet:development_merge_30from
vadi2:development_merge_30
Mar 27, 2017
Merged

Resolve all conflicts in mudlet.{cpp,h} [ci skip]#449
SlySven merged 1 commit intoMudlet:development_merge_30from
vadi2:development_merge_30

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Mar 27, 2017

QString const plus keeping AC's memory leak fixes.

QString const plus keeping AC's memory leak fixes.
Copy link
Copy Markdown
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work.

@SlySven SlySven merged commit 74a5631 into Mudlet:development_merge_30 Mar 27, 2017
@vadi2 vadi2 deleted the development_merge_30 branch March 28, 2017 03:05
Copy link
Copy Markdown
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪲 Uh, oh, I can't see how this slipped in to the header file:

 signals:
 
    void                         signal_editorTextOptionsChanged( QTextOption::Flags );
    void                         signal_profileMapReloadRequested( QList<QString> );
 
 signals:
 
    void                         signal_editorTextOptionsChanged( QTextOption::Flags );
    void                         signal_profileMapReloadRequested( QList<QString> );

but it is broken.

mehulmathur16 pushed a commit to mehulmathur16/Mudlet that referenced this pull request Feb 16, 2024
Co-authored-by: Mischa Alff <mischa@mutate.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants