Version: advance master to form start point for future work#441
Version: advance master to form start point for future work#441vadi2 merged 1 commit intoMudlet:masterfrom
Conversation
It is my understanding that urgent bug fixes for the Release 3.0.0 need to be based on a version with the same version major.minor.patch "Sematic Version" string but, until actually "released" will carry a "-dev" build suffix. This commit will introduce the change so that the resultant point in the repository becomes the start point for such fixes and other work. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Have I got this right, now? #441 was wrong but I would like to get a start point set up for the bug fixes we need on top of Release 3.0.0 and until (I think) we can complete the merging of the development branch this will be what those fixes need to work off/start from. |
|
Don't get too carried away with this...
…On Sun, 26 Mar 2017 11:21 pm Stephen Lyons, ***@***.***> wrote:
@SlySven <https://github.com/SlySven> requested your review on:
Mudlet/Mudlet#441 <#441> Version:
advance master to form start point for future work.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#441 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAGxjK4YAS5YtGUPW0iDHrMjd8ChnO89ks5rptQtgaJpZM4Mpl24>
.
|
|
Can you do the merge for this Vadim, I don't want to get carried away... 😜 |
|
Okay so right after I pressed merge I realised that this is on |
|
I wanted to submit a revert PR but decided to hold off until we figured this out. Nonetheless, the github UI already created a revert commit that I can't get to go away. I've gotten so used to PRs coming into |
|
For changes to be made we need to have a starting point, doesn't this become that starting point? Otherwise part of any PR would be something that then needed to take the code away from being labelled as if it was the release version - this does that and become the (future) development branch until we can get the existing "development" branch properly merged in. 😕 |
|
But we don't work on
|
It is my understanding that urgent bug fixes for the Release 3.0.0 need to be based on a version with the same version major.minor.patch "Sematic Version" string but, until actually "released" will carry a "-dev" build suffix. This commit will introduce the change so that the resultant point in the repository becomes the start point for such fixes and other work.
Signed-off-by: Stephen Lyons slysven@virginmedia.com