(release_30)BugFix_buttonCommandUpAndDownRedux_modulesWithToolBars#431
Conversation
This is ANOTHER attempt to get the Command Up and Down for buttons restored to Mudlet to get the release_30 branch ready for release. Previous attempts got bogged down in trying to do too much in one swell foop. This provides the minimum IMHO to get the missing functionality back and to fix a significant bug in the previous handling of toolbars that were inserted into modules. It is not everything that is wanted for the final release but represents a functional package of changes that are hopefully possible to swallow in one chunk. It DOES NOT fix the behaviour of push-down buttons not sending the right thing on every press - I am still investigating that urgently (I do have some ideas); also the layout in the editor when some elements have been necessarily been hidden is not perfect. I have got a solution for that but it is better wrapped up in a separate (series of) commit(s). Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
vadi2
left a comment
There was a problem hiding this comment.
It works, sort of, the up/down fields toggle fine and you can enter commands in them.
However, if you create a new button, give it the down button command, and try pressing it - only every 2nd press will make the button do something. I suspecet it's related to the up/down toggle bug where disabling up toggle still makes it switch.
I'll approve it though - and if you can iron out the toggle bug before final, it'll be extra sugar on top ;)
I will do final merges sometime on Friday 2017/03/24 arvo since the release is in the evening CET time.
src/dlgTriggerEditor.cpp
Outdated
| mpActionsMainArea->label_command_down->hide(); | ||
| mpActionsMainArea->lineEdit_command_up->hide(); | ||
| mpActionsMainArea->lineEdit_command_down->hide(); | ||
| mpActionsMainArea->label_command_down->setText( tr( "Command;" ) ); |
|
The toggling thing will be a separate bugfix (for bug 1673672) - as intended - the code in that area is spread over several classes and I think things are being changed on each button press in more than one place at a time. You may see some surprising visual effects if you make the editor screen really tall - and there is that crushing effect mentioned in your recent post on bug 1652413 - I think I have a fix for that but it needs cleaning up the mess of .ui files involved with the editor and cutting a load of crud out of Unless it was about the small icons (we tend to use 48x48 for those however icons can be scaled down by the Qt Icon engine but never scaled up so we'll have to go through and provide a uniform set of, say 512x512 ones to fix THAT)...! |
Not much to say really! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Will merge later today when the CI succeeds and I am back on the case. Note to self: try to remember to keep the pre-payment electric meter topped-up ⚡ (or invest in a full size UPS) ⚡ ... |
|
OK, I agree with you, lets keep the scope of the PR small and merge it in.
…On Wed, Mar 22, 2017 at 11:58 AM Stephen Lyons ***@***.***> wrote:
Will merge later today when the CI succeeds and I am back on the case.
*Note to self: try to remember to keep the pre-payment electric meter
topped-up ⚡️ (or invest in a full size UPS) ⚡️ ...*
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#431 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAGxjG1Q95qxAjRx0pVjsZ0weT-1LvBNks5roP7pgaJpZM4MksU->
.
|
It now works in memory, without requiring to mmap the libraries again, which should make it work correctly on android when loading libraries directly from apk or appbundle files. The new code will keep track of readable memory maps and will translate read requests based on the offset of those memory maps, making sure that we actually can read whatever we are trying to read.
This is ANOTHER attempt to get the Command Up and Down for buttons restored to Mudlet to get the release_30 branch ready for release. Previous attempts got bogged down in trying to do too much in one swell foop.
This provides the minimum IMHO to get the missing functionality back and to fix a significant bug in the previous handling of toolbars that were inserted into modules.
It is not everything that is wanted for the final release but represents a functional package of changes that are hopefully possible to swallow in one chunk.
It DOES NOT fix the behaviour of push-down buttons not sending the right thing on every press - I am still investigating that urgently (I do have some ideas); also the layout in the editor when some elements have been necessarily been hidden is not perfect. I have got a solution for that but it is better wrapped up in a separate (series of) commit(s).
Signed-off-by: Stephen Lyons slysven@virginmedia.com