(release_30)partialRevert: restore compilation order on profile loading#416
Merged
vadi2 merged 1 commit intoMudlet:release_30from Mar 12, 2017
Conversation
In commit-18750755c8a8acbb35a5dd65478333923da6a8e1 (Pull Request Mudlet#373) a change was made that reordered the compilation of the Lua scripts for Mudlet items. This commit reverts that aspect to restore the compilation of parent (e.g. folder/container) items before their children. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Member
|
Agreed, best to put the cat back in the bag and sort this out later. This fixes Svof loading for me. @keneanung or @bunster, could you confirm the fix works for you as well? Cloning the |
Contributor
|
👍 This also fixed the problem for me. Didn't run into any startup errors. |
Member
|
Great, thanks for testing and the fix @SlySven . We move on! :) |
vadi2
approved these changes
Mar 12, 2017
mehulmathur16
pushed a commit
to mehulmathur16/Mudlet
that referenced
this pull request
Feb 16, 2024
This fixes an error reported by Windows Application Verifier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit 1875075 (Pull Request #373) a change was made that reordered the compilation of the Lua scripts for Mudlet items. This commit reverts that aspect to restore the compilation of parent (e.g. folder/container) items before their children.
Signed-off-by: Stephen Lyons slysven@virginmedia.com