(release_30)bugFix: make searches/checks for "xml" extension files not case sensi…#378
Merged
vadi2 merged 1 commit intoMudlet:release_30from Feb 12, 2017
Conversation
…tive This is likely the cause of bug: https://bugs.launchpad.net/mudlet/+bug/1417234 which is where a suitable file is having an extra xml extension added, probably because the MacOS File system and native file dialogues are not necessarily case sensitive and could produce a file with an extension XML rather than xml that would fail checks for the latter in the past. This is regarded as a "ShowStopper" bug for Mudlet 3.0 release... Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Member
|
It's a bug we added that we know of! Can't let the quality of the application go down. Of course that's a showstopper. |
mehulmathur16
pushed a commit
to mehulmathur16/Mudlet
that referenced
this pull request
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tive
This should address the cause of bug 1417234 which is where a suitable file is having an extra xml extension added, probably because the MacOS File system and native file dialogues are not necessarily case sensitive and could produce a file with an extension XML rather than xml that would fail checks for the latter in the past.
This is regarded as a "ShowStopper" bug for Mudlet 3.0 release...
Signed-off-by: Stephen Lyons slysven@virginmedia.com