Skip to content

(release_30)bugFix: make searches/checks for "xml" extension files not case sensi…#378

Merged
vadi2 merged 1 commit intoMudlet:release_30from
SlySven:(release_30)bugFix_appendOnlyOneXmlToExportPackage
Feb 12, 2017
Merged

(release_30)bugFix: make searches/checks for "xml" extension files not case sensi…#378
vadi2 merged 1 commit intoMudlet:release_30from
SlySven:(release_30)bugFix_appendOnlyOneXmlToExportPackage

Conversation

@SlySven
Copy link
Copy Markdown
Member

@SlySven SlySven commented Feb 12, 2017

…tive
This should address the cause of bug 1417234 which is where a suitable file is having an extra xml extension added, probably because the MacOS File system and native file dialogues are not necessarily case sensitive and could produce a file with an extension XML rather than xml that would fail checks for the latter in the past.

This is regarded as a "ShowStopper" bug for Mudlet 3.0 release...

Signed-off-by: Stephen Lyons slysven@virginmedia.com

…tive

This is likely the cause of bug:
https://bugs.launchpad.net/mudlet/+bug/1417234
which is where a suitable file is having an extra xml extension added,
probably because the MacOS File system and native file dialogues are not
necessarily case sensitive and could produce a file with an extension XML
rather than xml that would fail checks for the latter in the past.

This is regarded as a "ShowStopper" bug for Mudlet 3.0 release...

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
@SlySven SlySven changed the title (release_3)bugFix: make searches/checks for "xml" extension files not case sensi… (release_30)bugFix: make searches/checks for "xml" extension files not case sensi… Feb 12, 2017
@SlySven SlySven requested a review from vadi2 February 12, 2017 14:58
@SlySven SlySven self-assigned this Feb 12, 2017
@vadi2
Copy link
Copy Markdown
Member

vadi2 commented Feb 12, 2017

It's a bug we added that we know of! Can't let the quality of the application go down. Of course that's a showstopper.

@vadi2 vadi2 merged commit a875ef1 into Mudlet:release_30 Feb 12, 2017
@SlySven SlySven deleted the (release_30)bugFix_appendOnlyOneXmlToExportPackage branch March 3, 2017 19:56
@SlySven SlySven restored the (release_30)bugFix_appendOnlyOneXmlToExportPackage branch June 22, 2020 17:55
@SlySven SlySven deleted the (release_30)bugFix_appendOnlyOneXmlToExportPackage branch June 22, 2020 19:01
mehulmathur16 pushed a commit to mehulmathur16/Mudlet that referenced this pull request Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants