Performance improvement for Geyser HBox/VBox#3756
Merged
vadi2 merged 1 commit intoMudlet:developmentfrom May 13, 2020
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Scripts/GUI with many Geyser HBox/VBox should have a noticeable performance improvement
with this PR
Motivation for adding to Mudlet
I always avoided HBox/VBoxes for my GUI because they had an noticeable impact in the performance of Mudlet, which I didn't notice if I just use relative\percentage values to organize my elements.
It's also possible that my ancient laptop is the cause but it was always caused by Geyser HBoxes or VBoxes.
Other info (issues closed, discussion etc)
vboxHboxTest.zip
Download this testpackage to compare the performance on Mudlet 4.8 and this PR.
At least on my machine the performance improvement is very noticeable.
Another example is GUI for the new added Mud Carrion Fields.
On my machine if I try to resize the GUI by using the arrows (the ones from GUIFrame) everything hangs and is very slow.
On this PR resizing is as fast as someone would expect.
If no one else ever noticed performance issues just ignore this PR 😅