Add Linux build to Github Actions#3657
Merged
vadi2 merged 27 commits intoMudlet:developmentfrom Apr 21, 2020
Merged
Conversation
* Add link information against libdl.so as well * Remove (harmful?) lua library path definition
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
SlySven
reviewed
Apr 21, 2020
| os: [ubuntu-latest, macos-latest] | ||
| include: | ||
| # - os: windows-latest | ||
| # triplet: x64-windows |
Member
There was a problem hiding this comment.
That might have to be x32-windows 😆
SlySven
reviewed
Apr 21, 2020
| if: runner.os == 'macOS' | ||
| run: | | ||
| # these aren't available or don't work well in vcpkg | ||
| brew install pkg-config libzzip libzip |
Member
There was a problem hiding this comment.
It is a side issue but libzzip is no longer needed on MacOs - and if we change the luarock we bundle for the other OS from luazip to lua-zip it won't be for them either since #3648 went in!
SlySven
reviewed
Apr 21, 2020
Member
SlySven
left a comment
There was a problem hiding this comment.
I'm not really in a position to judge but since it does seem to compile and link it is looking promising.
Chris7
pushed a commit
to Chris7/Mudlet
that referenced
this pull request
Jan 2, 2022
* Add a Ubuntu build * Install homebrew dependencies only on macOS * Add Linux dependencies separate * Don't stop other builds on fail * Install libzip-dev on Linux * Sudo please * Try installing libglu1-mesa-dev * Install Pulse dev libraries * Add a workaround for Lua linking * Correct YAML * Back to a single line * Debug locations of libraries * Correct an extra / * Build Mudlet with tracing * Try -GNinja Multi-Config * Try not specifying a generator * Add link information against libdl.so as well (Mudlet#33) * Add link information against libdl.so as well * Remove (harmful?) lua library path definition * Show built output in the end * Added a run tests flag * Try appending gcc argument as well * Debug plugin loading * Use a single, generic compiler line * Remove the x's * Install libxkbcommon-x11-0 * Try launching Achaea profile * Finalise Linux CI build * Remove comment Co-authored-by: keneanung <keneanung@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Add Linux build to Github Actions
Motivation for adding to Mudlet
Run Linux build alongside macOS in Actions CI & see how well it stacks up to Travis.
Other info (issues closed, discussion etc)
Adds the Linux build only with "32 additions and 7 deletions." 😮
(doesn't do any packaging, though...)