Skip to content

Add getMudletInfo()#3633

Merged
vadi2 merged 3 commits intoMudlet:developmentfrom
vadi2:add-getmudletinfo
Apr 19, 2020
Merged

Add getMudletInfo()#3633
vadi2 merged 3 commits intoMudlet:developmentfrom
vadi2:add-getmudletinfo

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Apr 17, 2020

Brief overview of PR changes/additions

Add getMudletInfo() to see useful internal information. Here's how it looks like right now:

image

When internal M_ encodings will be available, they'll get printed too.

Motivation for adding to Mudlet

Minimize the complex/confusing debug information to just one spot. See #3579 for the need that arose.

Other info (issues closed, discussion etc)

Could also be helpful when asking for support. We should also make this available via the UI, so non-techies can easily obtain it and copy, like in Steam:

Workspace 1_525

@vadi2 vadi2 requested a review from a team as a code owner April 17, 2020 06:18
@vadi2 vadi2 requested review from a team April 17, 2020 06:18
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Apr 17, 2020

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@SlySven
Copy link
Copy Markdown
Member

SlySven commented Apr 17, 2020

💡 Given the generic function name I would recommend that we take subject(s) as optional string argument(s). If no arguments are given ot given it dumps a list of what subjects it has, if given the case insensitive word ALL it dumps all of them otherwise it dumps the (case insensitive) listed subjects in order given (or a message about that subject NOT being known in that version of Mudlet) - that would give an extensible but comprehensible mechanism and avoid us having to do a new function for each aspect, yet still allow as much data as possible to be extracted from prior Mudlet versions when a call is made in the future.

For the current detail I would grab the subject "server_encodings"/"servereencodings"

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Apr 17, 2020

Hm... we can add a filter later when we have more info, sure. For now there's nothing to filter, all information fits on screen fine.

Copy link
Copy Markdown
Contributor

@Kebap Kebap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Apr 19, 2020

@vadi2 vadi2 merged commit bc9ba44 into Mudlet:development Apr 19, 2020
@vadi2 vadi2 deleted the add-getmudletinfo branch April 19, 2020 10:42
@SlySven
Copy link
Copy Markdown
Member

SlySven commented Apr 20, 2020

💣 This is no bloody good - as it has been put in BEFORE the need for it has arisen from #3579 and it doesn't work for that as it treats the encodings as QStrings when they have changed to be QByteArrays and I am now having to debug which auto I am going to have to change to a QByteArray and other things in order to resolve the ambiguities... 😢

../src/TLuaInterpreter.cpp:3668:102: error: call to member function 'arg' is ambiguous
            return (originalEncoding == encodingName) ? originalEncoding : QStringLiteral("%1 (%2)").arg(encodingName, originalEncoding);
                                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Apr 20, 2020

[](auto encodingName) this one I believe

Chris7 pushed a commit to Chris7/Mudlet that referenced this pull request Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants