Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Member
Author
|
Ready for review. |
Member
|
I hope to have a splash-screen image we can add to the PR within the next couple of days - let me check how easy it would be to plumb into the setup... |
demonnic
approved these changes
Mar 26, 2020
Member
demonnic
left a comment
There was a problem hiding this comment.
nothing stands out to me as broken
Kebap
reviewed
Mar 26, 2020
Kebap
reviewed
Mar 26, 2020
Contributor
|
Emoji sizing looks somewhat off, but may be unrelated here |
Contributor
|
version string looks pretty indecipherable |
Co-Authored-By: Kebap <leckerkebap@gmx.li>
Member
Author
|
It's just in this PR - in an actual release it'll be |
Member
Author
|
Merging so I can work on the mac version. |
Contributor
Please do, because it currently says |
Member
Author
|
I'll work on rejigging to change to that. |
dicene
pushed a commit
to dicene/Mudlet
that referenced
this pull request
Mar 28, 2020
* Print folder structures with file listings * Change . to a - in filename as expected * Remove test echo * Use latest dblsqd... * Embed sha1 in Mudlet version for Windows * Quote the arguments * Use a consistent file path * Remove repetition and add a debug echo * Print contents of squirrel-packaging-prep as well * Use correct .nupkg filename * Wild guess at location of squirrel's releasify log * Workaround squirrel's lack of 2.0.0 semver support * Correct nupkg path for the semver workaround * Remove content print echo * Ensure the right commit ID is used in all places * Use latest dblsqd * Use currentRelease with a timestamp always * Update to latest dblsqd * Remove stray brace * Update copyright (force rebuild) * Echo deployurl to see if there's a space at the end * Trim trailing newline * Force rebuild * Check release name when comparing dates as well * Re-build to get a new version * Try another way of ignoring current release * Rebuild again to have a 2nd update * Add more debug echoes to version comparison * Perform case-insensitive comparison... * Trim debug echoes * Update tooltip text to be more explanatory * Don't clobber 'mudlet' in the start menu * Try another way of finding generated mudlet.exe * Add a debug echo to show contents of folder * Better 'no changelog available' message * Lowercase version everywhere for consistency * Another take at unique the Windows start menu * Revert "Another take at unique the Windows start menu" This reverts commit de2115b. * Declare nuspec not only for PTB This would have been a release-breaking bug. * Try setting the product name * Fix contains check in .pro * Fingers crossed contains check is now doing its job * Still not working - add a debug echo. * And another one. * Use a regex for contains * Remove debug echoes * Add a thanks message * Add a few more emojis. * Improve code quality * Clarify %1 for translators * Update to latest dblsqd - trim debug echoes * Remove debug echoes * Apply suggestions from code review Co-Authored-By: Kebap <leckerkebap@gmx.li> Co-authored-by: Kebap <leckerkebap@gmx.li>
Chris7
pushed a commit
to Chris7/Mudlet
that referenced
this pull request
Jan 2, 2022
* Print folder structures with file listings * Change . to a - in filename as expected * Remove test echo * Use latest dblsqd... * Embed sha1 in Mudlet version for Windows * Quote the arguments * Use a consistent file path * Remove repetition and add a debug echo * Print contents of squirrel-packaging-prep as well * Use correct .nupkg filename * Wild guess at location of squirrel's releasify log * Workaround squirrel's lack of 2.0.0 semver support * Correct nupkg path for the semver workaround * Remove content print echo * Ensure the right commit ID is used in all places * Use latest dblsqd * Use currentRelease with a timestamp always * Update to latest dblsqd * Remove stray brace * Update copyright (force rebuild) * Echo deployurl to see if there's a space at the end * Trim trailing newline * Force rebuild * Check release name when comparing dates as well * Re-build to get a new version * Try another way of ignoring current release * Rebuild again to have a 2nd update * Add more debug echoes to version comparison * Perform case-insensitive comparison... * Trim debug echoes * Update tooltip text to be more explanatory * Don't clobber 'mudlet' in the start menu * Try another way of finding generated mudlet.exe * Add a debug echo to show contents of folder * Better 'no changelog available' message * Lowercase version everywhere for consistency * Another take at unique the Windows start menu * Revert "Another take at unique the Windows start menu" This reverts commit de2115b. * Declare nuspec not only for PTB This would have been a release-breaking bug. * Try setting the product name * Fix contains check in .pro * Fingers crossed contains check is now doing its job * Still not working - add a debug echo. * And another one. * Use a regex for contains * Remove debug echoes * Add a thanks message * Add a few more emojis. * Improve code quality * Clarify %1 for translators * Update to latest dblsqd - trim debug echoes * Remove debug echoes * Apply suggestions from code review Co-Authored-By: Kebap <leckerkebap@gmx.li> Co-authored-by: Kebap <leckerkebap@gmx.li>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Debug why isn't it uploading to make.mudlet.org as it used to...
Motivation for adding to Mudlet
Windows ptb will be ready for use after this, I hope!
Other info (issues closed, discussion etc)
This is a good test build to install to see how the upgrade experience looks like: https://make.mudlet.org/snapshots/c0efe9/Mudlet-4.6.2-public-test-build-pr3506-1b720453-windows.exe