Skip to content

Only make PR to update translation texts if content changed#3438

Merged
vadi2 merged 19 commits intodevelopmentfrom
only-make-pr-on-changes
Mar 14, 2020
Merged

Only make PR to update translation texts if content changed#3438
vadi2 merged 19 commits intodevelopmentfrom
only-make-pr-on-changes

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Mar 13, 2020

Brief overview of PR changes/additions

Only make PR to update translation texts if content changed - because it currently makes PRs even if no lines were changed.

Motivation for adding to Mudlet

Less spam... from newly added automation.

Other info (issues closed, discussion etc)

I am sure my bash hackery can be done better!

@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Mar 13, 2020

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@vadi2 vadi2 requested a review from a team March 13, 2020 22:26
Copy link
Copy Markdown
Contributor

@Kebap Kebap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Mar 14, 2020

I've cut down on the amount of actions used by replacing it with another action - however the new action has difficulties updating existing PRs, see gr2m/create-or-update-pull-request-action#177. Waiting on resolution of that first.

Copy link
Copy Markdown
Member

@demonnic demonnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me

@vadi2 vadi2 merged commit 9f624e6 into development Mar 14, 2020
@vadi2 vadi2 deleted the only-make-pr-on-changes branch March 14, 2020 15:19
Chris7 pushed a commit to Chris7/Mudlet that referenced this pull request Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants