Skip to content

Re-set development#3417

Merged
vadi2 merged 2 commits intodevelopmentfrom
vadi2-patch-1
Mar 10, 2020
Merged

Re-set development#3417
vadi2 merged 2 commits intodevelopmentfrom
vadi2-patch-1

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Mar 10, 2020

Brief overview of PR changes/additions

Re-set development

Motivation for adding to Mudlet

So the autoupdater is disabled

Other info (issues closed, discussion etc)

@vadi2 vadi2 requested a review from a team March 10, 2020 16:12
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Mar 10, 2020

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@demonnic
Copy link
Copy Markdown
Member

Is resetting this after a release also on the list of things to automate around releases? If not, it probably should be.

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Mar 10, 2020

Well this is the tricky part: remember it's only set to release mode in the branch, and resetting the branch wouldn't make sense in case we need to do a hotfix. But when the branch is merged into development, it comes in the release mode.

So perhaps the right way is to re-set it before merging the branch?

Copy link
Copy Markdown
Member

@demonnic demonnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vadi2 vadi2 merged commit 2a5079a into development Mar 10, 2020
@vadi2 vadi2 deleted the vadi2-patch-1 branch March 10, 2020 19:14
Chris7 pushed a commit to Chris7/Mudlet that referenced this pull request Jan 2, 2022
* Update mudlet.pro

* Update CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants