Skip to content

Tableutils tests#3416

Merged
demonnic merged 2 commits intoMudlet:developmentfrom
demonnic:tableutils_tests
Mar 10, 2020
Merged

Tableutils tests#3416
demonnic merged 2 commits intoMudlet:developmentfrom
demonnic:tableutils_tests

Conversation

@demonnic
Copy link
Copy Markdown
Member

@demonnic demonnic commented Mar 10, 2020

Brief overview of PR changes/additions

  • Adds tests for functions in TableUtils.lua
  • Fixes a minor issue with the error message for table.is_empty the tests caught

Motivation for adding to Mudlet

TEST ALL THE THINGS!

Other info (issues closed, discussion etc)

image

@demonnic demonnic requested a review from a team March 10, 2020 15:42
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Mar 10, 2020 •
edited
Loading

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@demonnic
Copy link
Copy Markdown
Member Author

demonnic commented Mar 10, 2020 •
edited
Loading

It is possible to leave the pending stubs but not have them clutter the output, either through setting the suppressPendings option in the script in run-tests.xml or by removing the second argument to the pending() calls. When using the TAP output it shows as Ok and skipped, so shouldn't halt CI to leave them reported, but could get unwieldy if we stub a lot of tests.

That being said, the end goal is to get as close to 100% coverage as possible, and having it tell how many pending tests are still to write is potential motivation for writing them and also shows progress as the number on the right goes down and the one on the left goes up.

keneanung
keneanung approved these changes Mar 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@keneanung keneanung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the pending output staying as it is.

@demonnic demonnic merged commit 5d4e3b2 into Mudlet:development Mar 10, 2020
@demonnic demonnic deleted the tableutils_tests branch March 10, 2020 19:36
@demonnic
Copy link
Copy Markdown
Member Author

demonnic commented Mar 10, 2020

#3408

@demonnic demonnic linked an issue Mar 10, 2020 that may be closed by this pull request
Add busted (or luaunit) tests as part of CI #3408
Closed
Chris7 pushed a commit to Chris7/Mudlet that referenced this pull request Jan 2, 2022
@demonnic @Chris7
Tableutils tests (Mudlet#3416)
550261a 
* Fixing typo in error message for table.is_empty
* Adding tests and increasing coverage for TableUtils spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadi2 vadi2 vadi2 approved these changes

@keneanung keneanung keneanung approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add busted (or luaunit) tests as part of CI

3 participants

@demonnic @vadi2 @keneanung