Skip to content

Workflow: automatic translation text updates weekly and on pushes to release branches#3412

Merged
vadi2 merged 36 commits intodevelopmentfrom
migrate-actions-to-yaml
Mar 12, 2020
Merged

Workflow: automatic translation text updates weekly and on pushes to release branches#3412
vadi2 merged 36 commits intodevelopmentfrom
migrate-actions-to-yaml

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Mar 9, 2020

Brief overview of PR changes/additions

This will automatically create a PR to update text in development once a new release branch is created, and also on a weekly basis on Friday midnight. Idea being to do step 1.2 of release process automatically.

Though due to the way the Github hooks work, it'll not just update texts on the release branch creation, but any time it's pushed to as well. Hopefully that doesn't result in duplicate PRs - the only way to test that is to merge this in first and then create a fake release branch.

Motivation for adding to Mudlet

Less manual release work.

Other info (issues closed, discussion etc)

Builds upon the work @keneanung did earlier in https://github.com/Mudlet/Mudlet/pull/2712/files and supersedes #3410.

Closes #3401.

@vadi2 vadi2 added this to the 4.7.0 milestone Mar 9, 2020
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Mar 9, 2020

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Mar 9, 2020

ee41111 failed to trigger a github actions run, so I deleted a file - but it's still not running.

@demonnic
Copy link
Copy Markdown
Member

demonnic commented Mar 9, 2020

top comment says this supercedes itself, I think maybe the wrong thing was pasted in?

@vadi2 vadi2 marked this pull request as ready for review March 10, 2020 19:36
@vadi2 vadi2 requested a review from a team March 10, 2020 19:37
@vadi2 vadi2 changed the title Enable automatic translation strings updates Workflow: automatic translation text updates on release Mar 10, 2020
@vadi2 vadi2 changed the title Workflow: automatic translation text updates on release Workflow: automatic translation text updates weekly and on pushes to release branches Mar 11, 2020
@vadi2 vadi2 merged commit 19241d5 into development Mar 12, 2020
@vadi2 vadi2 deleted the migrate-actions-to-yaml branch March 12, 2020 09:04
@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Mar 12, 2020

I've created a fake release branch to test the "on new release branch" trigger and while the branch with updated texts was made, creating a PR for it failed with:

fatal: Refusing to fetch into current branch refs/heads/release-test-auto-translation of non-bare repository

No clue what that is trying to say! Creating PRs worked before, so this is odd.

Chris7 pushed a commit to Chris7/Mudlet that referenced this pull request Jan 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a github action to automatically update translation strings

3 participants