Skip to content

setModulePriority() now works when called from install event#3327

Merged
vadi2 merged 1 commit intoMudlet:developmentfrom
vadi2:allow-module-prio-on-install
Feb 14, 2020
Merged

setModulePriority() now works when called from install event#3327
vadi2 merged 1 commit intoMudlet:developmentfrom
vadi2:allow-module-prio-on-install

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Feb 9, 2020

Brief overview of PR changes/additions

setModulePriority() now works when called from install event - it previously didn't because the map holding priorities didn't have the module name inserted into it as it should have.

Motivation for adding to Mudlet

Bugfix.

Other info (issues closed, discussion etc)

Fix #3324

@vadi2 vadi2 added this to the 4.5.0 milestone Feb 9, 2020
@vadi2 vadi2 requested a review from a team as a code owner February 9, 2020 04:24
@vadi2 vadi2 requested a review from a team February 9, 2020 04:24
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Feb 9, 2020 •
edited
Loading

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

PhoenixCodes
PhoenixCodes approved these changes Feb 9, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@PhoenixCodes PhoenixCodes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My testing shows this resolves the issue, and I haven't encountered any bugs in the install or uninstall process due to this. Seems to be the right fix!

Windows 10

@vadi2 vadi2 merged commit eb6e0f6 into Mudlet:development Feb 14, 2020
@vadi2 vadi2 deleted the allow-module-prio-on-install branch February 14, 2020 04:32
dicene pushed a commit to dicene/Mudlet that referenced this pull request Feb 19, 2020
@vadi2 @dicene
setModulePriority() now when called from install event (Mudlet#3327)
386e9ed
vadi2 added a commit to vadi2/Mudlet that referenced this pull request Feb 21, 2020
@vadi2
Revert "setModulePriority() now when called from install event (Mudle…
6666ffd 
…t#3327)"

This reverts commit eb6e0f6.
vadi2 added a commit that referenced this pull request Feb 27, 2020
@vadi2
Fix module priorities not to get lost (#3354)
e99c482 
* Revert "setModulePriority() now when called from install event (#3327)"

This reverts commit eb6e0f6.

* Improve API error message quality
vadi2 added a commit that referenced this pull request Feb 27, 2020
@vadi2
Fix module priorities not to get lost (#3354)
8fc99ba 
* Revert "setModulePriority() now when called from install event (#3327)"

This reverts commit eb6e0f6.

* Improve API error message quality

(cherry picked from commit e99c482)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demonnic demonnic demonnic approved these changes

+1 more reviewer

@PhoenixCodes PhoenixCodes PhoenixCodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

setModulePrio does not work at time of install event being raised

3 participants

@vadi2 @demonnic @PhoenixCodes