Refactor: remove multiple redundent semi-colons following closing braces#3249
Merged
SlySven merged 8 commits intoMudlet:developmentfrom Nov 24, 2019
Conversation
One was pointed out to me by CodeFactor in a recent commit to a PR and when I looked I found a few more! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
We are getting CI setup failures in this area and this is an initial step to investigate the problem. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
I took too much off of the revised script! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
…o grep This is so that `pcre2` will not be considered for `pcre` as a package - the former has an updated formula currently and was tripping the code to try and update the latter package - but that package does not need it. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
…o grep This is so that `pcre2` will not be considered for `pcre` as a package - the former has an updated formula currently and was tripping the code to try and update the latter package - but that package does not need it. The previous commit was incomplete! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
…output Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Merged
vadi2
approved these changes
Nov 24, 2019
Member
vadi2
left a comment
There was a problem hiding this comment.
Thanks for fixing the CI problem!
dicene
pushed a commit
to dicene/Mudlet
that referenced
this pull request
Feb 19, 2020
…ces (Mudlet#3249) * Refactor: remove multiple redundent semi-colons following closing braces One was pointed out to me by CodeFactor in a recent commit to a PR and when I looked I found a few more! During the testing of this PR there were CI failures for the macOS case which turned out to be because `pcre2` was being considered for `pcre` as a package - the former has an updated formula currently and was tripping the code to try and update the latter package - but that package does not need it. The fix was to add the `-w` (whole-word) option to a couple of calls to `grep`. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One was pointed out to me by CodeFactor in a recent commit to a PR and when
I looked I found a few more!
Signed-off-by: Stephen Lyons slysven@virginmedia.com