Skip to content

Use latest VS image in Appveyor#3238

Merged
vadi2 merged 4 commits intodevelopmentfrom
Use-latest-VS-image
Nov 17, 2019
Merged

Use latest VS image in Appveyor#3238
vadi2 merged 4 commits intodevelopmentfrom
Use-latest-VS-image

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Nov 12, 2019

Brief overview of PR changes/additions

Use latest VS image in Appveyor

Motivation for adding to Mudlet

More Qt version options, and less change of appveyor removing a Qt version we need under us.

Other info (issues closed, discussion etc)

Hopefully we don't get #2926 again nor #3211.

@vadi2 vadi2 added this to the 4.4.0 milestone Nov 12, 2019
@vadi2 vadi2 requested a review from a team November 12, 2019 15:14
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Nov 12, 2019

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Nov 12, 2019

Font seems ok ✔️

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Nov 12, 2019

Not affected by the scrollbar in the text editor either ✔️

Looks good to be merged to me.

@vadi2 vadi2 merged commit 4572a91 into development Nov 17, 2019
@vadi2 vadi2 deleted the Use-latest-VS-image branch November 17, 2019 08:56
dicene pushed a commit to dicene/Mudlet that referenced this pull request Feb 19, 2020
* Use latest VS image in Appveyor

* Use Qt 5.13.0 on appveyor builds

(cherry picked from commit 81ac771)

* Up to Qt 5.13.2

* Install right version in SDK as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants