Remove temporary aliases when calling resetProfile()#3233
Remove temporary aliases when calling resetProfile()#3233vadi2 merged 3 commits intoMudlet:developmentfrom aaronjoslyn:development
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
Yeah, this seems like an oversight. Thanks for the fix! Let's wait on the CI to populate the build links to test. |
|
After playing around with it a bit, I noticed I wasn't disabling/cleaning up/re-enabling aliases in the same way as the triggers, etc. I've added that in too. |
|
@aaronjoslyn can you pull in latest |
vadi2
left a comment
There was a problem hiding this comment.
Works great! Thanks for the fix, and apologies for the delay.
|
@aaronjoslyn mind coming by Discord and letting us know how was your experience with contributing? Curious to see if setting up the compile / navigating code was hard or any other remarks :) |
* Remove temporary aliases when calling resetProfile() * Ensure aliases are disabled, cleaned up and then enabled when resetting profile
Brief overview of PR changes/additions
This PR causes aliases created with
tempAliasto be reset upon callingresetProfile(), similar totempTrigger, etc.Motivation for adding to Mudlet
It makes it a lot easier to enable a development flow where your aliases are defined in external source files and required via
require/dofile. You can create triggers, aliases, etc. withtempAlias/tempTrigger/etc, and simply callresetProfilewhen you want to reload changes. Currently this isn't the case, since aliases are not reloaded, causing old aliases to hang around.Other info (issues closed, discussion etc)