Add simple 2min autosave for notepad contents#3226
Merged
vadi2 merged 5 commits intoMudlet:developmentfrom Nov 11, 2019
Merged
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
SlySven
requested changes
Nov 8, 2019
Member
SlySven
left a comment
There was a problem hiding this comment.
I have only inspected this visually so I may be a little off the mark but there are a few points that I think could need attention...
SlySven
approved these changes
Nov 10, 2019
dicene
pushed a commit
to dicene/Mudlet
that referenced
this pull request
Feb 19, 2020
* Add simple 2min autosave * Remove test debug * Le review feedback * Don't load-save straight away
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Add simple 2min autosave for notepad contents. Right now, notepad is only saved when the profile is closed.
Motivation for adding to Mudlet
In the rare case that Mudlet or computer crashes.
Other info (issues closed, discussion etc)
Only autosave if content was changed, to prevent laptop battery drain every 2min for no reason.