Skip to content

Don't use Qt 5.13 for Windows builds#3212

Merged
vadi2 merged 2 commits intoMudlet:developmentfrom
vadi2:revert-qt-5.13
Nov 1, 2019
Merged

Don't use Qt 5.13 for Windows builds#3212
vadi2 merged 2 commits intoMudlet:developmentfrom
vadi2:revert-qt-5.13

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Nov 1, 2019

Brief overview of PR changes/additions

Don't use Qt 5.13 for Windows builds, go back to latest LTS available.

Motivation for adding to Mudlet

It's the cause for #3211 😒

Other info (issues closed, discussion etc)

Fix #3211.

Perhaps newer Qt fixes it, but we're pretty limited in what we can select on the 2017 image, need to upgrade to 2019!

@vadi2 vadi2 added this to the 4.3.0 milestone Nov 1, 2019
@vadi2 vadi2 requested a review from a team November 1, 2019 06:05
@add-deployment-links
Copy link
Copy Markdown

add-deployment-links bot commented Nov 1, 2019 •
edited
Loading

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Nov 1, 2019

It fixes the issue in my testing.

@vadi2 vadi2 mentioned this pull request Nov 1, 2019
Merged
keneanung
keneanung approved these changes Nov 1, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@keneanung keneanung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look into the image upgrade for the next cycle

@vadi2 vadi2 merged commit 350348e into Mudlet:development Nov 1, 2019
@vadi2 vadi2 deleted the revert-qt-5.13 branch November 1, 2019 09:04
@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Nov 1, 2019

Thank you!

Would you mind pulling in latest development to #3166 to test it?

@keneanung
Copy link
Copy Markdown
Member

keneanung commented Nov 1, 2019

I'm on mobile, but I will ASAP.

@keneanung
Copy link
Copy Markdown
Member

keneanung commented Nov 1, 2019

Hm, looks like I am not allowed to do changes there...

@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Nov 1, 2019

Weird, I was! Can @demonnic?

dicene pushed a commit to dicene/Mudlet that referenced this pull request Feb 19, 2020
@vadi2 @dicene
Don't use Qt 5.13 for Windows builds (Mudlet#3212)
3b57bb2 
* Revert "Install Qt 5.13.0 via SDK"

This reverts commit 2737c0a.

* Revert "Use Qt 5.13.0 on appveyor builds"

This reverts commit 81ac771.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keneanung keneanung keneanung approved these changes

Assignees

@keneanung keneanung

Labels

None yet

Projects

None yet

Milestone

4.3.0

Development

Successfully merging this pull request may close these issues.

Latest development squishes up fonts in Windows

2 participants

@vadi2 @keneanung