Upstream-BugFix: change out wchar_t type which is too narrow on Windows#3207
Merged
SlySven merged 1 commit intoMudlet:developmentfrom Oct 31, 2019
Conversation
This is a bugfix that I got into upstream and fixes some issues on Windows where some Emojis (off of the BMP) were not being correctly typed - they were being identified as private use characters on Windows because the argument to a function was not wide enough (did not have enough bits) to convay the values required. I believe this may be a simpler fix for the issue that PR: Mudlet#2943 was trying to fix. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Member
Author
|
Upstream fix is: ridiculousfish/widecharwidth#7 . |
vadi2
approved these changes
Oct 31, 2019
|
Just to thank you for your work, this is how we're exploiting this bugfix:
|
Member
|
Very nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bugfix that I got into upstream and fixes some issues on Windows where some Emojis (off of the BMP) were not being correctly typed - they were being identified as private use characters on Windows because the argument to a function was not wide enough (did not have enough bits) to convey the values required.
I believe this may be a simpler fix for the issue that PR #2943 was trying to fix.
Signed-off-by: Stephen Lyons slysven@virginmedia.com
Brief overview of PR changes/additions
Motivation for adding to Mudlet
Other info (issues closed, discussion etc)