BugFix: change out wchar_t type which is too narrow on Windows#7
Merged
ridiculousfish merged 1 commit intoridiculousfish:masterfrom Oct 30, 2019
Conversation
Specifically it is only 16 bits and as we are using it to pass a Unicode codepoint it needs to have at least 21! This does mean however that any surrogate pairs i.e. UTF-16 encoded characters that are not on the BMP and are conveyed by TWO 16 bit values, MUST be converted to a UTF-32 value before being fed to `(int) widechar_wcwidth(int32_t c)`! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically it is only 16 bits and as we are using it to pass a Unicode codepoint it needs to have at least 21! This does mean however that any surrogate pairs i.e. UTF-16 encoded characters that are not on the BMP and are conveyed by TWO 16 bit values, MUST be converted to a UTF-32 value before being fed to
(int) widechar_wcwidth(int32_t c)!Signed-off-by: Stephen Lyons slysven@virginmedia.com