Cmake improve git submodule initialization#3171
Merged
keneanung merged 3 commits intoMudlet:developmentfrom Oct 18, 2019
Merged
Cmake improve git submodule initialization#3171keneanung merged 3 commits intoMudlet:developmentfrom
keneanung merged 3 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
vadi2
approved these changes
Oct 17, 2019
cmake/InitGitSubmodule.cmake
Outdated
| set(MULTI_VALUE_ARGS "") # not used | ||
| cmake_parse_arguments(GIT_SM "${OPTIONS}" "${ONE_VALUE_ARGS}" "${MULTI_VALUE_ARGS}" ${ARGN}) | ||
|
|
||
| # check arguments for existance |
cmake/InitGitSubmodule.cmake
Outdated
| @@ -0,0 +1,49 @@ | |||
| ############################################### | |||
Member
Author
|
Adapted the comments |
vadi2
approved these changes
Oct 18, 2019
dicene
pushed a commit
to dicene/Mudlet
that referenced
this pull request
Feb 19, 2020
* Add function to initialize git submodules * Use function for retrieving git submodules * Add GPL header
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Apr 5, 2022
There are files now in Mudlet that seem to have been forgotten from being added to these variables so they can be seen in Qt Creator, they are: * OTHER_FILES: * ./.devcontainer/Dockerfile (added by Mudlet#4087) * ./.devcontainer/devcontainer.json (added by Mudlet#4087) * ./.devcontainer/library-scripts/desktop-lite-debian.sh (added by Mudlet#4088) * ./.github/workflows/generate-changelog.yml (added by Mudlet#6006) * ./CI/appveyor.validate_deployment.ps1 (added by Mudlet#3493) * ./CI/generate-changelog.lua (renamed from ./CI/generate-ptb-changelog.lua by Mudlet#6002, that file created by Mudlet#3517) * ./CI/travis.validate_deployment.sh (added by Mudlet#3493) * ./CI/update-autocompletion.lua (added by Mudlet#3452) * ./dangerfile.js (added by Mudlet#5489) * ./docker/.env.template (added by Mudlet#5047) * DISTFILES: * ./.clang-tidy (added by Mudlet#4858) * ./cmake/FindLua51.cmake (added by Mudlet#3167) * ./cmake/FindSparkle.cmake (added Mudlet#3477) * ./cmake/FindZZIPLIB.cmake (added by Mudlet#3630) * ./cmake/IncludeOptionalModule.cmake (added by Mudlet#3174) * ./cmake/InitGitSubmodule.cmake (added by Mudlet#3171) The following files have gone away: * OTHER_FILES: * ./.github/workflows/whitespace-linter.yml (removed by Mudlet#4152) * ./.travis.yml (removed by Mudlet#5611) * ./README (renamed to ./dev_README by Mudlet#439, removed by Mudlet#1169) Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
added a commit
that referenced
this pull request
Apr 5, 2022
…les (#6037) This PR had three commits: * The first commit just sorts in a case insensitive manner the files in the OTHER_FILES and DISTFILES QMake variables. This is a precursor to making changes to them. * The second swaps some files between QMake OTHER_FILES and DISTFILES variables. Technically the latter are for files that are needed to go into a source tarball that the traditional GNU 'make dist' operation would produce. As such it does not seem reasonable to include CI/CB control files in it. Conversely the run-time LUA files that Mudlet needs definitely should be included and so this commit moves them from the OTHER_FILES variable, whose contents are merely files that we want to show up in the Qt Creator IDE so they can be seen, searched and edited from there. * The third changes the contents of QMake OTHER_FILES and DISTFILES variables as there are files now in Mudlet that seem to have been forgotten from being added to these variables so they can be seen in Qt Creator, they are: * OTHER_FILES: * ./.devcontainer/Dockerfile (added by Setup Mudlet for C++ Github Codespace #4087) * ./.devcontainer/devcontainer.json (added by Setup Mudlet for C++ Github Codespace #4087) * ./.devcontainer/library-scripts/desktop-lite-debian.sh (added by Open Mudlet remotely using Github Codespaces #4088) * ./.github/workflows/generate-changelog.yml (added by Infrastructure: add workflow to create changelog from the web #6006) * ./CI/appveyor.validate_deployment.ps1 (added by Add updater validation to linux/macos/windows release builds #3493) * ./CI/generate-changelog.lua (renamed from ./CI/generate-ptb-changelog.lua by Infrastucture: update changelog generator to handle releases as well #6002, that file created by Add a changelog generator for PTB releases #3517) * ./CI/travis.validate_deployment.sh (added by Add updater validation to linux/macos/windows release builds #3493) * ./CI/update-autocompletion.lua (added by Add action for automatic updates of Mudlet's autocompletion #3452) * ./dangerfile.js (added by Infrastructure: danger checks in JS #5489) * ./docker/.env.template (added by Docker development support #5047) * DISTFILES: * ./.clang-tidy (added by Add automated check to verify improvements against Mudlet's C++ style guide #4858) * ./cmake/FindLua51.cmake (added by Modernize cmake files (part 1) #3167) * ./cmake/FindSparkle.cmake (added Improve cmake osx #3477) * ./cmake/FindZZIPLIB.cmake (added by Build Mudlet for macOS with Github Actions #3630) * ./cmake/IncludeOptionalModule.cmake (added by Cmake improve optional module check #3174) * ./cmake/InitGitSubmodule.cmake (added by Cmake improve git submodule initialization #3171) Also, the following files have gone away: * OTHER_FILES: * ./.github/workflows/whitespace-linter.yml (removed by Delete whitespace-linter action #4152) * ./.travis.yml (removed by Infrastructure: delete .travis.yml #5611) * ./README (renamed to ./dev_README by Release 3.0 merge into master #439, removed by Merge 3.3.0 development into master #1169) Signed-off-by: Stephen Lyons slysven@virginmedia.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
This moves the cmake code to initalize git submodules to an own function.
Motivation for adding to Mudlet
Use the DRY (don't repeat yourself) principle and also cleans our code up quite a bit.
Other info (issues closed, discussion etc)
Relates to #1392