Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
SlySven
left a comment
There was a problem hiding this comment.
👎 No - lets not forget that making an omelette requires you at some point to break some eggs. Some changes cannot reasonably be introduced in a piecemeal fashion - yes I accept that in an ideal situation each change can be broken down into smaller chunks - but some things do make fundamental changes internally and they cannot easily be done bit-by-bit - for instance does #3131 or #3132 fall within the limits that are to be imposed?
Instead of:
Pull Requests that overhaul large pieces of functionality at once will not be accepted: through experience, they bring more pain than they are worth. Being really difficult to discuss, test, and reason about, they are banned.
I would substitute:
Pull Requests that overhaul large pieces of functionality at once will be very hard for us to accept: through experience, they bring much pain that can be more than they are really worth. Being difficult to discuss, test, and reason about, they are not going to be welcomed and may end up being abandoned and unused.
|
#3131 falls under the proposed rule - so I'll have to break it up into smaller PRs, and I definitely can. Not everything has to go in at once, there are underlying changes I did that I can put in at first, get merged, and then make use of them in later PRs. #3132 - like other rules in Contributing, I think we should go easy on external contributors, to encourage contributions. There's a limit of course to what we can accomodate but all in all, we can hold ourselves to a higher standard easier. |
keneanung
left a comment
There was a problem hiding this comment.
Yes, please. They are hard to review and take much longer. Additionally, the change requests are usually much more devastating due to the sheer amount.
|
@SlySven ? |
|
Is my suggested alternative going to fly or not? I am reluctant to announce a "We are never going to accept something" when there is a possibility that "It might be accepted but you don't want to bet on that" is closer to the mark... |
|
That's what we had before... it didn't work! So yes, now it has to be split up. |
To go along with the crowd and not hold up approval - even though I don't wholly agree with it.
Brief overview of PR changes/additions
Ban mega PRs.
Motivation for adding to Mudlet
Very bad experiences with them.
Other info (issues closed, discussion etc)
We've always frowned upon them, but tolerated them, and honestly it's not working out. It's a frustrating and disappointing experience for everybody involved: the PR author, the core team, and the players.