Closed
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
Reduce code duplication.
…-support # Conflicts: # src/dlgConnectionProfiles.cpp # src/mudlet.cpp # src/mudlet.h
…-support # Conflicts: # src/dlgConnectionProfiles.cpp # src/mudlet.cpp # src/mudlet.h
e796d48 to
e2f24a3
Compare
Merged
…-support # Conflicts: # src/CMakeLists.txt # src/mudlet.cpp # src/mudlet.qrc
Member
Author
|
Closing as it hasn't moved in a while, code is still in |
Member
Author
<key>CFBundleURLTypes</key>
<array>
<dict>
<key>CFBundleTypeRole</key>
<string>Shell</string>
<key>CFBundleURLName</key>
<string>org.mudlet.mudlet</string>
<key>CFBundleURLSchemes</key>
<array>
<string>telnet</string>
<string>mudlet</string>
</array>
</dict>
</array>macOS registration key I have from my research. |
Member
Author
|
This might be relevant: https://doc.qt.io/qt-5/qdesktopservices.html#setUrlHandler |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Add support for Mudlet to handle
telnet://URIs. See #689 for the design discussion.Motivation for adding to Mudlet
So game websites can easily open their game in Mudlet!
Other info (issues closed, discussion etc)
This is a continuation of #2666, but started from scratch with a design I was more comfortable with.
Close #689.
Resources for registering URI on Windows:
Resources for registering URI on macOS:
Resources for registering URI on Linux: