Conversation
…h user@host:port format
…_URI # Conflicts: # src/main.cpp # src/mudlet.h # src/ui/profile_preferences.ui
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
Ah - the support for actually registering Mudlet to open |
| #elif defined(Q_OS_LINUX) | ||
| registerTelnetURI->setEnabled(true); | ||
| #elif defined(Q_OS_FREEBSD) | ||
| registerTelnetURI->setEnabled(false); |
There was a problem hiding this comment.
I will test this when I can get around to booting FreeBSD
There was a problem hiding this comment.
I don't think it does anything there right now... hold off for now.
There was a problem hiding this comment.
I mean it should be very similar - I hope...
| if (tolower(argument) == 'q') { | ||
| action |= 4; | ||
| } | ||
| } else { |
There was a problem hiding this comment.
We might want to review this to specify a command line argument as an introducer for a profile to load - with another one to NOT autoload any that are already set to autorun on start-up - it will make the string to fire up the Mudlet instance a bit longer though...
There was a problem hiding this comment.
i.e. instead of something like /path/to/executable/mudlet game.domain.org:portNumber we use /path/to/executable/mudlet -l game.domain.org:portNumber so that the -l (or --load) option indicates that what follows is a Game server address to connect to - this makes it a bit easier to parse the command line as I understand it. It is more flexible if the user wants to open more than one profile at a time as then, if there are other options that can (in the future) be applied from the command line, the options can be applied to a specific profile.
…_URI # Conflicts: # src/dlgProfilePreferences.cpp # src/mudlet.h
…_URI # Conflicts: # src/main.cpp # src/mudlet.h
|
Closing in favour of #3131. |
Brief overview of PR changes/additions
Add support for telnet:// links
Motivation for adding to Mudlet
#689
Other info (issues closed, discussion etc)
@jerzerisz started on this work in his branch last October but never submitted a PR, I found this in his branch and updated to latest
development