Adding c/d/h variants of insertLink, echoPopup, and insertPopup#3009
Adding c/d/h variants of insertLink, echoPopup, and insertPopup#3009demonnic merged 13 commits intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
There has been a change to the edbee-lib widget sub-module - I think we may even have changed the source repository - whilst locally that can be pulled in with a |
|
🔍 Oooh, it looks to me as though the commit bdd66b1 may have reverted the edbee-lib submodule back to the old one... 😮 |
|
good eye, not sure how that even got introduced. I'll revert that changeset and reapply the actual lua changes |
This reverts commit bdd66b1.
|
Should be good now |
…opup to Geyser.MiniConsole
|
Realized Geyser didn't even have all the functions we already had setup, let alone the ones in this PR, so I added a bunch of geyser wrappers too. |
vadi2
left a comment
There was a problem hiding this comment.
cinsertPopup("<red>activities<reset> to do", {[[send "sleep"]], [[send "sit"]], [[send "stand"]]}, {"sleep", "sit", "stand"}) doesn't seem to do anything, just eats the command.
| insertLink(self.name, ...) | ||
| end | ||
|
|
||
| --- inserts clickable text with right-click menu into the miniconsole at the end of the current line |
There was a problem hiding this comment.
These will appear in the Geyser ldoc pages but don't give any real guidance on how to be used... but this is an issue with existing functions above too.
There was a problem hiding this comment.
They're largely wrappers around already documented stuff in the wiki, I could run through and include links to the wiki for the base functions they wrap
|
I'll check cinsertPopup in particular in a moment here. |
|
So it turns out this is because insertPopup eats the command if you pass "main" as the window name, rather than acting against the main window. So it looks like this is a bug in insertPopup. |
|
OK, I'll get that fixed first, since otherwise without that this PR isn't of super quality. |
|
OK, check out #3013. |
|
OK, with that issue fixed, update this branch and I'll re-test. |
|
Alright, links to mudlet wiki for base functions added, merged upstream development back into this branch to pick up fix. |
…et#3009) * Adding c/d/h variants of insertLink, echoPopup, and insertPopup * Adding c/d/h versions of echoLink, insertLink, echoPopup, and insertPopup to Geyser.MiniConsole * Adding urls to the wiki for c/d/h insert/echoLink/Popup wrapper functions
Brief overview of PR changes/additions
adds the c/d/h versions of the insertLink, echoPopup, and insertPopup functions. Already have echo, insertText and echoLink so I figured I should add the rest when I went to use cechoPopup and discovered it didn't exist yet.
Motivation for adding to Mudlet
True up API. Surprised nobody has asked for these before (that I could find with a brief search)
Other info (issues closed, discussion etc)