Fixes timestamp selection regression in 4.0#2980
Merged
vadi2 merged 1 commit intoMudlet:developmentfrom Aug 20, 2019
Merged
Conversation
… check for timestamp clicking.
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
vadi2
approved these changes
Aug 14, 2019
Member
vadi2
left a comment
There was a problem hiding this comment.
Seems to work 👍 I'd get others to test it as this isn't the most intuitive thing to reason about (coordinates translation).
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Aug 21, 2019
Note that this pretty much removes/reverts/replaces Mudlet#2980 as I warned it might... Conflicts resolved in: * src/TTextEdit.cpp For some reason I found that during testing the merge it was necessary to add a couple of JSON related headers to `cTelnet.cpp` - this may be a result of a different compilation option that I tend to use...? Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Fixes #2978
Motivation for adding to Mudlet
Other info (issues closed, discussion etc)