(release_30)bugfix: correct errors in Lua command error messages#298
Merged
SlySven merged 1 commit intoMudlet:release_30from Mar 14, 2016
Conversation
There has been a fair amount of copy and paste in creating various Lua commands - but the error messages have not always been revised when this has happened. With a bit of *nix shell-fu I have identified the cases where this has happened and changed the function that is given as the name where an error occurred. Note that this does not attempt to improve the formatting to bring the standard up to current guidelines - merely it fixes gross errors that will definitely be confusing to anyone seeing the messages. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
added a commit
that referenced
this pull request
Mar 14, 2016
…orMessageFunctionNames (release_30)bugfix: correct errors in Lua command error messages
mehulmathur16
pushed a commit
to mehulmathur16/Mudlet
that referenced
this pull request
Feb 16, 2024
And avoid a trailing newline for custom loggers. fixes Mudlet#298
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been a fair amount of copy and paste in creating various Lua commands - but the error messages have not always been revised when this has happened. With a bit of *nix shell-fu I have identified the cases where this has happened and changed the function that is given as the name where an error occurred.
Note that this does not attempt to improve the formatting to bring the standard up to current guidelines - merely it fixes gross errors that will definitely be confusing to anyone seeing the messages.
This is the release_30 version of the development version #297 and, line numbers, aside it makes the same changes.
Signed-off-by: Stephen Lyons slysven@virginmedia.com