BugFix: save & load custom line colors in map format version less than 20#2559
Merged
SlySven merged 1 commit intoMudlet:developmentfrom May 29, 2019
Conversation
…an 20 This will close Mudlet#2558 . The bug was made in Mudlet#2106 which has been present since before Mudlet 2.16.0 was released· Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
|
Hey there! Thanks for helping Mudlet improve. 🌟 You can directly test the changes here:
No need to install anything - just unzip and run. |
keneanung
approved these changes
May 24, 2019
Member
keneanung
left a comment
There was a problem hiding this comment.
Not much to check here for UI purposes.
The code changes look sensible as well.
vadi2
approved these changes
May 27, 2019
Member
Author
|
Oi @Kebap! This is my PR and my web-browser is set to spell checking in my language - you retitling it to Americanish seems a bit heavy handed... 😝 |
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Jul 6, 2019
Although Mudlet#2559 fixed a problem with custom exit line colour handling, it did not do anything to fixup maps that were generated prior to that fix being inserted into the code-base. This PR does so by converting any missing or empty (no colour components) to have a default RED colour. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
added a commit
that referenced
this pull request
Jul 6, 2019
Although #2559 fixed a problem with custom exit line colour handling, it did not do anything to fixup maps that were generated prior to that fix being inserted into the code-base. This PR does so by converting any missing or empty (no colour components) to have a default RED colour. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will close #2558 .
The bug was made in #2106 which has been present since before Mudlet 2.16.0 was released·
Signed-off-by: Stephen Lyons slysven@virginmedia.com