Remove dead code for html copy starting in the middle of the line#2365
Merged
vadi2 merged 1 commit intoMudlet:developmentfrom Feb 23, 2019
Merged
Remove dead code for html copy starting in the middle of the line#2365vadi2 merged 1 commit intoMudlet:developmentfrom
vadi2 merged 1 commit intoMudlet:developmentfrom
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 You can directly test the changes here:
No need to install anything - just unzip and run. |
SlySven
approved these changes
Feb 22, 2019
Member
SlySven
left a comment
There was a problem hiding this comment.
🤔 yeah, that does seem to be the case.
Member
|
👣 🔫 🤦♂️ The purpose of the section of the code is not primarily to set the |
Member
|
That is what is causing #2367 ! |
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Feb 23, 2019
A recent PR: Mudlet#2365 removed code which was rendered ineffective by an implementation error in: Mudlet#984 however it causes an error which has just been raised in: Mudlet#2367 This PR should fix the issue and it also fixes another bug that I can see in that underlines are not being reproduced in the HTML files because of a typo in that part of the style detail for `<span ...>` entries which used "text-decoration: undeline" instead of: "text-decoration: underline"! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
added a commit
that referenced
this pull request
Feb 24, 2019
A recent PR: #2365 removed code which was rendered ineffective by an implementation error in: #984 however it causes an error which has just been raised in: #2367 This PR should fix the issue and it also fixes another bug that I can see in that underlines are not being reproduced in the HTML files because of a typo in that part of the style detail for `<span ...>` entries which used "text-decoration: undeline" instead of: "text-decoration: underline"! Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Does not seem to have any effect because the variable is always set to
trueupon initialisation.Motivation for adding to Mudlet
Less code!
Other info (issues closed, discussion etc)
Thanks to Coverity for reporting it.