Merged
Conversation
vadi2
added a commit
to vadi2/Mudlet
that referenced
this pull request
Jun 7, 2018
This reverts commit eba31d2. # Conflicts: # src/dlgProfilePreferences.cpp # src/dlgProfilePreferences.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1176 is blocking 3.3 release and we narrowed it down to Mudlet compiled with MinGW 5.3 being the issue. Unfortunately earlier MinGW available is 4.9, which does not have C++14 compatbility, so I've gowngraded some of the new features I've had to make use of.