Merged
Conversation
SlySven
approved these changes
Jul 2, 2017
Member
SlySven
left a comment
There was a problem hiding this comment.
It seems a bit awkward that we have to change the development code to set it to be the release version and then change it back afterwards - but hey, if it gets the job done...
Member
Author
|
Yeah it is. Happy to hear about a better solution 😕 |
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Jul 3, 2017
…udlet#1173) I think that that absence of an initialisation value for the (bool) mTemporary flag recent moved out of the Mudlet "items" derived classes and down to the base class was causing these issues as "temporary" items are not shown in the editor and not saved at the end of a session. Technically a value of not zero is a "true" value according to C coding standards but C++ tends to use the specific integer values of 0 and 1 (not -1) for false and true - I suspect there was some ambiguity when another value was being seen when a derived item was instantiated without this boolean being set to a definite value. I have taken the liberty to also go through and mark the template file up for `const`ness... and also put in C++14 `explicit` on the constructors so that there is no automatic use of the one without the argument when a "parent" argument is given and vice-versa. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
vadi2
pushed a commit
that referenced
this pull request
Jul 7, 2017
…1173) I think that that absence of an initialisation value for the (bool) mTemporary flag recent moved out of the Mudlet "items" derived classes and down to the base class was causing these issues as "temporary" items are not shown in the editor and not saved at the end of a session. Technically a value of not zero is a "true" value according to C coding standards but C++ tends to use the specific integer values of 0 and 1 (not -1) for false and true - I suspect there was some ambiguity when another value was being seen when a derived item was instantiated without this boolean being set to a definite value. I have taken the liberty to also go through and mark the template file up for `const`ness... and also put in C++14 `explicit` on the constructors so that there is no automatic use of the one without the argument when a "parent" argument is given and vice-versa. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven
added a commit
to SlySven/Mudlet
that referenced
this pull request
Jun 22, 2020
…udlet#1173) I think that that absence of an initialisation value for the (bool) mTemporary flag recent moved out of the Mudlet "items" derived classes and down to the base class was causing these issues as "temporary" items are not shown in the editor and not saved at the end of a session. Technically a value of not zero is a "true" value according to C coding standards but C++ tends to use the specific integer values of 0 and 1 (not -1) for false and true - I suspect there was some ambiguity when another value was being seen when a derived item was instantiated without this boolean being set to a definite value. Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.