Skip to content

Re-set development to -dev#1173

Merged
vadi2 merged 2 commits intodevelopmentfrom
continue-3.4-development
Jul 3, 2017
Merged

Re-set development to -dev#1173
vadi2 merged 2 commits intodevelopmentfrom
continue-3.4-development

Conversation

@vadi2
Copy link
Copy Markdown
Member

@vadi2 vadi2 commented Jul 2, 2017

No description provided.

@vadi2 vadi2 added the 1 - Ready label Jul 2, 2017
@vadi2 vadi2 requested a review from a team July 2, 2017 18:21
Copy link
Copy Markdown
Member

@SlySven SlySven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a bit awkward that we have to change the development code to set it to be the release version and then change it back afterwards - but hey, if it gets the job done...

@vadi2 vadi2 merged commit bbb7c5b into development Jul 3, 2017
@vadi2 vadi2 deleted the continue-3.4-development branch July 3, 2017 03:29
@vadi2
Copy link
Copy Markdown
Member Author

vadi2 commented Jul 3, 2017

Yeah it is. Happy to hear about a better solution 😕

SlySven added a commit to SlySven/Mudlet that referenced this pull request Jul 3, 2017
…udlet#1173)

I think that that absence of an initialisation value for the (bool)
mTemporary flag recent moved out of the Mudlet "items" derived classes and
down to the base class was causing these issues as "temporary" items are
not shown in the editor and not saved at the end of a session.  Technically
a value of not zero is a "true" value according to C coding standards but
C++ tends to use the specific integer values of 0 and 1 (not -1) for false
and true - I suspect there was some ambiguity when another value was being
seen when a derived item was instantiated without this boolean being set
to a definite value.

I have taken the liberty to also go through and mark the template file up
for `const`ness... and also put in C++14 `explicit` on the constructors
so that there is no automatic use of the one without the argument when a
"parent" argument is given and vice-versa.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
vadi2 pushed a commit that referenced this pull request Jul 7, 2017
…1173)

I think that that absence of an initialisation value for the (bool)
mTemporary flag recent moved out of the Mudlet "items" derived classes and
down to the base class was causing these issues as "temporary" items are
not shown in the editor and not saved at the end of a session.  Technically
a value of not zero is a "true" value according to C coding standards but
C++ tends to use the specific integer values of 0 and 1 (not -1) for false
and true - I suspect there was some ambiguity when another value was being
seen when a derived item was instantiated without this boolean being set
to a definite value.

I have taken the liberty to also go through and mark the template file up
for `const`ness... and also put in C++14 `explicit` on the constructors
so that there is no automatic use of the one without the argument when a
"parent" argument is given and vice-versa.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
SlySven added a commit to SlySven/Mudlet that referenced this pull request Jun 22, 2020
…udlet#1173)

I think that that absence of an initialisation value for the (bool)
mTemporary flag recent moved out of the Mudlet "items" derived classes and
down to the base class was causing these issues as "temporary" items are
not shown in the editor and not saved at the end of a session.  Technically
a value of not zero is a "true" value according to C coding standards but
C++ tends to use the specific integer values of 0 and 1 (not -1) for false
and true - I suspect there was some ambiguity when another value was being
seen when a derived item was instantiated without this boolean being set
to a definite value.

Signed-off-by: Stephen Lyons <slysven@virginmedia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants