Add previous order state in database for solver message by arkanoider · Pull Request #472 · MostroP2P/mostro

arkanoider · 2025-04-02T12:11:59Z

added here the previous order state in database dispute table. It will be sent when admin takes a dispute in the solver message.

In relation to this feature you can you locally this pull request of mostro-core.

@Catrya
use as usual in mostrod and mostro-cli the cargo.toml with this modification:

[patch.crates-io]
mostro-core ={ path = "catrya/path/mostro-core" }

Summary by CodeRabbit

New Features
- Enhanced dispute processing now records the order’s status at the time a dispute is raised, providing improved context and transparency.
- This update enriches dispute tracking without altering existing workflows.
Database Changes
- Added a new column order_previous_status to the disputes table, which is required for all records.
Dependency Updates
- Updated mostro-core dependency version from 0.6.35 to 0.6.36.

coderabbitai · 2025-04-02T12:12:07Z

Walkthrough

This pull request introduces a new non-null column order_previous_status in the disputes table via a migration script. Additionally, the dispute_action function in the dispute module has been updated to initialize the Dispute object with both order_id and the order's current status. These changes ensure that dispute records capture the order status at the time of creation without altering the existing error handling or token generation process.

Changes

File Path	Change Summary
migrations/..._disputes.sql	Added new column `order_previous_status varchar(10) not null` to `disputes` table.
src/app/dispute.rs	Modified `dispute_action` function to initialize a `Dispute` object with both `order_id` and `order.status.clone()`, enhancing dispute record creation.
Cargo.toml	Updated `mostro-core` dependency version from `0.6.35` to `0.6.36`.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant DisputeService
    participant OrderService
    participant Database

    Client->>DisputeService: Request dispute creation
    DisputeService->>OrderService: Retrieve order details
    OrderService-->>DisputeService: Order details (incl. current status)
    DisputeService->>Database: Insert dispute (order_id, order_previous_status)
    Database-->>DisputeService: Confirmation of insertion
    DisputeService-->>Client: Dispute creation confirmation

Suggested reviewers

Catrya
grunch

Poem

In a field of code so wide,
I hopped along with joyful stride.
New columns bloom, disputes align,
Enhancements made, oh how divine!
With ASCII hops and bits so bright,
The code dances into the light.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc19914 and de49af5.

📒 Files selected for processing (1)

Cargo.toml (1 hunks)

✅ Files skipped from review due to trivial changes (1)

Cargo.toml

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Catrya

tACK

arkanoider · 2025-04-03T06:44:28Z

Bumped mostro-core version to 6.36.

Ready to merge @grunch

grunch

utACK

@arkanoider

* 📝 Add docstrings to `feature-full-privacy-mode-checks` (#455) * add feature to check correctly if order is full privacy or normal * 📝 Add docstrings to `feature-full-privacy-mode-checks` Docstrings generation was requested by @arkanoider. * #454 (comment) The following files were modified: * `src/app/order.rs` * `src/util.rs` --------- Co-authored-by: arkanoider <github.913zc@simplelogin.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: arkanoider <113362043+arkanoider@users.noreply.github.com> * Fix network in order event (#452) Now in orers event 38383 the network that comes out is the correct one * Feature anyhow removal (#459) * remove of anyhow dependency start * removed anyhow dependecy * remove patch from cargo.toml * Update mostro-core version --------- Co-authored-by: Francisco Calderón <fjcalderon@gmail.com> * Feature disputes (#463) * Feature: dispute fix for new logic * fix for coop cancel case * Add logic for info message about dispute for solver * first working dispute info message for admin after taking disputes * added fields to dispute info message for solver * removed some probably useless and refactored a bit admin-take-dispute function * clippy suggestion * other cosmetics to admin take file * some other cosmetics on admin-take-dispute file * fix on admin-take * Update admin_take_dispute.rs * fixed a wrong search of order id in admin take file@ * Fix: added correct check to add solver from admin cli * fix: wrong check on admin cancel * Fix initiator pubkey: now is the trade key of initiator not identity * quick fix for full privacy orders * new logic with mixed full privacy - regular reputation mode * Update cargo toml to compile with version 0.6.32 of mostro-core - this is in preparation for migrating to nostr-sdk 0.40 * rollback sdk to 0.38 version to merge disputes - we will come back to 0.40 when we will fix signature issue * Update mostro-core dependency --------- Co-authored-by: Francisco Calderón <fjcalderon@gmail.com> * added correction for the case of buyer adding back a new invoice after payment failure (#462) * Fix for nostr sdk 40 issue on incoming message (#465) * testing sdk 40 * fix for sdk 40 * cleaned cargo.toml * Bump mostro core version --------- Co-authored-by: Francisco Calderón <fjcalderon@gmail.com> * fix: sends order with an updated 'status' field as the reply to add-invoice when there is a preimage (#464) * Feature-nip69-order-status (#467) * feature: align to nip69 order status in nostr event * Improved in progress nip69 logic * refined event states of the order with nip69 request * add another check to avoid multiple events with in-progress state * Privacy range order fix (#468) * add optional field for users in full privacy inside solver message * To be tested - privacy range child order fix * fix cargo.toml * bumped mostro-core version to 6.35 * New user or privacy order send same user info with zeros (#471) * new user or privacy order send same user info with zeros * fix days field and removed some println! macro with nicer tracing messages * bumped mostro-core version to 6.36 and added requested fix to compile * Add previous order state in database for solver message (#472) * add previous state in database for solver message * bumped mostro-core version to 6.36 * Taker info message to maker. I think that could be modifies in a more generic UserInfo. (#473) * added logic to send infos to maker when an order is taken * Add takers info message for maker * fix cargo.toml * set peer pubkey to empty string when notifying taker reputation to maker * moved user info message to the right point of the order flow * fix cargo.toml * changed message struct from UserDisputeInfo to UserInfo * fix: get master keys for user infos * Bumped mostro-core to version 6.38 * fix for buy order flow with message to maker (#479) * Rabbit fixes --------- Co-authored-by: Francisco Calderón <fjcalderon@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Catrya <140891948+Catrya@users.noreply.github.com> Co-authored-by: Bilthon <bilthon@gmail.com>

add previous state in database for solver message

cc19914

arkanoider requested review from Catrya and grunch April 2, 2025 12:12

Catrya approved these changes Apr 2, 2025

View reviewed changes

arkanoider mentioned this pull request Apr 2, 2025

Show to the dispute solver the status previous to Dispute #469

Closed

bumped mostro-core version to 6.36

de49af5

Merge branch 'develop' into feature-prev-state

938af0f

grunch approved these changes Apr 3, 2025

View reviewed changes

grunch merged commit c07b377 into develop Apr 3, 2025

grunch deleted the feature-prev-state branch April 3, 2025 16:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add previous order state in database for solver message#472

Add previous order state in database for solver message#472
grunch merged 3 commits into
developfrom
feature-prev-state

arkanoider commented Apr 2, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 2, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Catrya left a comment

Uh oh!

arkanoider commented Apr 3, 2025

Uh oh!

grunch left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

arkanoider commented Apr 2, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Catrya left a comment

Choose a reason for hiding this comment

Uh oh!

arkanoider commented Apr 3, 2025

Uh oh!

grunch left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arkanoider commented Apr 2, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 2, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)