used sdk code to avoid code duplication - reduced user_rate.rs file#117
Merged
Conversation
Otso-Hirvikangas
added a commit
to Otso-Hirvikangas/mostro
that referenced
this pull request
Sep 19, 2025
The mostro-core PR MostroP2P#117 has been merged, so we can now use the main repository instead of the fork.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @grunch ,
this need to be completely tested. Reduced a lot
user_rate.rsfile because nostr-sdk has implemented the same logic. So we are duplicating code. I admit i didn't test anything, but it should work, and in case we coul surely fix eventual issues to use the sdk code and avoid code duplication.Waiting for comments...