Skip to content

feat: increase session expiration from 72 hours to 30 days#569

Merged
grunch merged 1 commit into
mainfrom
increase-cleanup-time
Apr 9, 2026
Merged

feat: increase session expiration from 72 hours to 30 days#569
grunch merged 1 commit into
mainfrom
increase-cleanup-time

Conversation

@Catrya

@Catrya Catrya commented Apr 9, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member
  • Users reported orders disappearing too quickly from My Trades
  • Increased Config.sessionExpirationHours from 72 to 720 (30 days)
  • Updated architecture documentation to reflect the new expiration window

Summary by CodeRabbit

  • Documentation

    • Updated session management documentation to reflect revised expiration timelines.

  • Chores

    • Extended session expiration window from 3 days to 30 days.

@Catrya
feat: increase session expiration from 72 hours to 30 days
d606b14 
  - Users reported orders disappearing too quickly from My Trades
  - Increased Config.sessionExpirationHours from 72 to 720 (30 days)
  - Updated architecture documentation to reflect the new expiration window
@coderabbitai

coderabbitai Bot commented Apr 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e5120f6c-3ff3-41f0-82b0-1d88659a6de0

📥 Commits

Reviewing files that changed from the base of the PR and between 2eded43 and d606b14.

📒 Files selected for processing (4)
  • docs/architecture/APP_INITIALIZATION_ANALYSIS.md
  • docs/architecture/SESSION_AND_KEY_MANAGEMENT.md
  • docs/architecture/TIMEOUT_DETECTION_AND_SESSION_CLEANUP.md
  • lib/core/config.dart

Walkthrough

The pull request updates the configured session expiration duration from 72 hours (3 days) to 720 hours (30 days) across documentation files and the configuration constant, maintaining consistency between implementation and documentation.

Changes

Cohort / File(s) Summary
Documentation Updates
docs/architecture/APP_INITIALIZATION_ANALYSIS.md, docs/architecture/SESSION_AND_KEY_MANAGEMENT.md, docs/architecture/TIMEOUT_DETECTION_AND_SESSION_CLEANUP.md		 Updated session expiration duration from 72 hours (3 days) to 720 hours (30 days) in session/timeout-related documentation.
Configuration Constant
lib/core/config.dart		 Updated Config.sessionExpirationHours static constant value from 72 to 720, extending session expiration window to 30 days.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • grunch

Poem

A rabbit hops with eager pace, 🐰
Sessions now have longer grace—
From three brief days to thirty more,
Users smile and give applause! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: increasing session expiration duration from 72 hours to 30 days, which is the core modification across all changed files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch increase-cleanup-time

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

grunch
grunch approved these changes Apr 9, 2026
View reviewed changes

@grunch grunch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grunch grunch merged commit 3be5ed3 into main Apr 9, 2026
2 checks passed
@grunch grunch deleted the increase-cleanup-time branch April 9, 2026 17:30
@coderabbitai coderabbitai Bot mentioned this pull request Apr 9, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grunch grunch grunch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Catrya @grunch