Skip to content

Set automatic session deletion from 36 to 72 hours#330

Merged
grunch merged 1 commit into
mainfrom
72h_clean_sessions
Oct 21, 2025
Merged

Set automatic session deletion from 36 to 72 hours#330
grunch merged 1 commit into
mainfrom
72h_clean_sessions

Conversation

@Catrya

@Catrya Catrya commented Oct 17, 2025 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Extended session timeout from 36 hours to 72 hours, allowing users to remain logged in longer before requiring re-authentication. This provides improved convenience for continuous work sessions while maintaining security protocols.

@coderabbitai

coderabbitai Bot commented Oct 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Walkthrough

Updated the session expiration configuration constant in lib/core/config.dart, increasing sessionExpirationHours from 36 to 72 hours. This adjusts the session timeout duration without introducing new logic or modifying control flow.

Changes

Cohort / File(s) Change Summary
Configuration Update
lib/core/config.dart		 Updated sessionExpirationHours static constant from 36 to 72, extending the session expiration timeout duration

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A session lives longer, seventy-two hours strong,
Double the time for users to belong,
No logic twisted, just numbers changed,
A simple tweak, expertly arranged! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Set automatic session deletion from 36 to 72 hours" directly aligns with the changeset, which updates the sessionExpirationHours constant from 36 to 72 hours in lib/core/config.dart. The title is clear, specific, and concise, providing meaningful information about the primary change rather than using vague terms or being overly broad. A teammate scanning the repository history would immediately understand that this change adjusts the session timeout duration without confusion or ambiguity.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 72h_clean_sessions
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 873b2b6 and c036eec.

📒 Files selected for processing (1)
  • lib/core/config.dart (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
lib/**/*.dart

📄 CodeRabbit inference engine (CLAUDE.md)

lib/**/*.dart: Use post-frame callbacks for UI side effects (e.g., SnackBars/dialogs)
Use S.of(context).keyName for all user-facing strings (no hardcoded text)
Always use localized strings instead of hardcoded text
Pass BuildContext to methods that need localization (use S.of(context))
Check mounted before using BuildContext after async gaps
Use const constructors where possible

Name Riverpod providers as Provider or Notifier

Files:

  • lib/core/config.dart
**/*.dart

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.dart: All code comments must be in English
Use clear, concise English for variable and function names
Maintain zero flutter analyze issues
Use latest Flutter/Dart APIs (e.g., prefer withValues() over withOpacity())
Remove unused imports and dependencies

**/*.dart: Use Dart formatter defaults (two-space indentation, trailing commas) and run flutter format before committing
Resolve all Flutter analyzer warnings (flutter analyze must be clean)

Files:

  • lib/core/config.dart
lib/core/**

📄 CodeRabbit inference engine (AGENTS.md)

Keep dependency wiring in lib/core/

Files:

  • lib/core/config.dart
🔇 Additional comments (1)
lib/core/config.dart (1)

40-40: Verified—no issues found. The change is correct and compatible across all usages.

All three usages of sessionExpirationHours consistently apply the same logic: calculating an expiration cutoff by subtracting the duration from the current time. Extending from 36 to 72 hours simply increases the session retention window, with no breaking changes or logic conflicts in the session cleanup and expiration flows.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

grunch
grunch approved these changes Oct 21, 2025
View reviewed changes

@grunch grunch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grunch grunch merged commit ffa6966 into main Oct 21, 2025
2 checks passed
@grunch grunch deleted the 72h_clean_sessions branch October 21, 2025 19:05
This was referenced Apr 9, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grunch grunch grunch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Catrya @grunch